chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm - Issue 22831005: Use visible entry for website settings dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm

Issue 22831005: Use visible entry for website settings dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix TabSpecificContentSettings Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm

diff --git a/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm b/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm

index 1e96e67163f74d9919356f742de72206a451d0bf..619f4d8082f3af264c8295a49e62c2ece10f8177 100644

--- a/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm

+++ b/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm

@@ -98,7 +98,8 @@ bool LocationIconDecoration::OnMousePressed(NSRect frame) {

WebContents* tab = owner_->GetWebContents();

const NavigationController& controller = tab->GetController();

- NavigationEntry* nav_entry = controller.GetActiveEntry();

+ // Important to use GetVisibleEntry to match what's showing in the omnibox.

+ NavigationEntry* nav_entry = controller.GetVisibleEntry();

if (!nav_entry) {

NOTREACHED();

return true;