Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 22831003: Pass checked values to HLoadNamedField, removing the need for extra type-check field. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2819 matching lines...) Expand 10 before | Expand all | Expand 10 after
2830 2830
2831 2831
2832 void HParameter::PrintDataTo(StringStream* stream) { 2832 void HParameter::PrintDataTo(StringStream* stream) {
2833 stream->Add("%u", index()); 2833 stream->Add("%u", index());
2834 } 2834 }
2835 2835
2836 2836
2837 void HLoadNamedField::PrintDataTo(StringStream* stream) { 2837 void HLoadNamedField::PrintDataTo(StringStream* stream) {
2838 object()->PrintNameTo(stream); 2838 object()->PrintNameTo(stream);
2839 access_.PrintTo(stream); 2839 access_.PrintTo(stream);
2840 if (HasTypeCheck()) {
2841 stream->Add(" ");
2842 typecheck()->PrintNameTo(stream);
2843 }
2844 } 2840 }
2845 2841
2846 2842
2847 HCheckMaps* HCheckMaps::New(Zone* zone, 2843 HCheckMaps* HCheckMaps::New(Zone* zone,
2848 HValue* context, 2844 HValue* context,
2849 HValue* value, 2845 HValue* value,
2850 Handle<Map> map, 2846 Handle<Map> map,
2851 CompilationInfo* info, 2847 CompilationInfo* info,
2852 HValue* typecheck) { 2848 HValue* typecheck) {
2853 HCheckMaps* check_map = new(zone) HCheckMaps(value, zone, typecheck); 2849 HCheckMaps* check_map = new(zone) HCheckMaps(value, zone, typecheck);
(...skipping 1144 matching lines...) Expand 10 before | Expand all | Expand 10 after
3998 break; 3994 break;
3999 case kExternalMemory: 3995 case kExternalMemory:
4000 stream->Add("[external-memory]"); 3996 stream->Add("[external-memory]");
4001 break; 3997 break;
4002 } 3998 }
4003 3999
4004 stream->Add("@%d", offset()); 4000 stream->Add("@%d", offset());
4005 } 4001 }
4006 4002
4007 } } // namespace v8::internal 4003 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698