Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 22828010: Migrate from using deprecated api in webview in Files.app. (Closed)

Created:
7 years, 4 months ago by mtomasz
Modified:
7 years, 4 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Migrate from using deprecated api in webview in Files.app. The webview has changed and this patch upgrades it to reflect these changes. WebView.onBeforeSendHeaders is not accessible via WebView.request.onBeforeSendHeaders. TEST=browser_tests BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217756

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/file_manager/js/share_dialog.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
mtomasz
@yoshiki: PTAL. Thanks.
7 years, 4 months ago (2013-08-15 02:16:14 UTC) #1
yoshiki
lgtm
7 years, 4 months ago (2013-08-15 02:17:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/22828010/1
7 years, 4 months ago (2013-08-15 02:19:46 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-15 07:09:07 UTC) #4
Message was sent while issue was closed.
Change committed as 217756

Powered by Google App Engine
This is Rietveld 408576698