Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: lib/src/transform/import_inliner.dart

Issue 22825012: Introduce transformers for: (Closed) Base URL: git@github.com:dart-lang/web-ui.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/src/transform/import_inliner.dart
diff --git a/lib/src/transform/import_inliner.dart b/lib/src/transform/import_inliner.dart
new file mode 100644
index 0000000000000000000000000000000000000000..a730bb216405615571216070ea81e6404e2d5245
--- /dev/null
+++ b/lib/src/transform/import_inliner.dart
@@ -0,0 +1,88 @@
+// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+/** Transfomer that inlines polymer-element definitions from html imports. */
+library polymer.src.transform.import_inliner;
+
+import 'dart:async';
+
+import 'package:barback/barback.dart';
+import 'package:html5lib/dom.dart' show Document, DocumentFragment;
+import 'common.dart';
+
+/** Recursively inlines polymer-element definitions from html imports. */
+// TODO(sigmund): what about other things in html-imports, like scripts?
Jennifer Messerly 2013/08/19 22:57:26 inline *all the things* \o/
Siggi Cherem (dart-lang) 2013/08/21 20:35:42 :-) filed a bug and updated the TODO with more det
+class ImportedElementInliner extends Transformer {
+ Future<bool> isPrimary(Asset input) =>
+ new Future.value(input.id.extension == ".html");
+
+ Future apply(Transform transform) {
+ var seen = new Set<AssetId>();
+ var elements = [];
+ var id = transform.primaryId;
+ seen.add(id);
+ return getPrimaryContent(transform).then((content) {
+ var document = parseHtml(content, id.path, transform.logger);
+ var future = _visitImports(document, id, transform, seen, elements);
+ return future.then((importsFound) {
+ if (!importsFound) {
+ transform.addOutput(new Asset.fromString(id, content));
+ return;
+ }
+
+ for (var tag in document.queryAll('link')) {
+ if (tag.attributes['rel'] == 'import') {
+ tag.remove();
+ }
+ }
+ var fragment = new DocumentFragment()..nodes.addAll(elements);
+ document.body.insertBefore(fragment,
+ document.body.nodes.length == 0 ? null : document.body.nodes[0]);
Jennifer Messerly 2013/08/19 22:57:26 TODO(jmesserly): add Node.firstChild to html5lib h
Siggi Cherem (dart-lang) 2013/08/21 20:35:42 Done.
+ transform.addOutput(new Asset.fromString(id, document.outerHtml));
+ });
+ });
+ }
+
+ /**
+ * Visits imports in [document] and add their polymer-element definitions to
+ * [element], unless they have already been [seen]. Elements are added in the
Bob Nystrom 2013/08/19 22:28:59 "[element]" -> "[elements]".
Siggi Cherem (dart-lang) 2013/08/21 20:35:42 Done.
+ * order they appear, transitive imports are added first.
+ */
+ Future<bool> _visitImports(Document document, AssetId sourceId,
+ Transform transform, Set<AssetId> seen, List<Node> elements) {
+ var importIds = [];
+ bool hasImports = false;
+ for (var tag in document.queryAll('link')) {
+ if (tag.attributes['rel'] != 'import') continue;
+ var href = tag.attributes['href'];
+ var id = resolve(sourceId, href, transform.logger, tag.sourceSpan);
+ hasImports = true;
+ if (id == null || seen.contains(id)) continue;
+ importIds.add(id);
+ }
+
+ if (importIds.isEmpty) return new Future.value(hasImports);
+
+ // Note: we need to preserve the import order in the generated output.
+ return Future.forEach(importIds, (id) {
+ if (seen.contains(id)) return new Future.value(null);
+ seen.add(id);
+ return _collectPolymerElements(id, transform, seen, elements);
+ }).then((_) => true);
+ }
+
+ /**
+ * Loads an asset identified by [id], visits its imports and collects it's
+ * polymer-element definitions.
+ */
+ Future _collectPolymerElements(
+ AssetId id, Transform transform, Set<AssetId> seen, List elements) {
+ return getContent(transform, id)
+ .then((content) => parseHtml(content, id.path, transform.logger))
+ .then((document) {
+ return _visitImports(document, id, transform, seen, elements)
Jennifer Messerly 2013/08/19 22:57:26 this might look better with =>
Siggi Cherem (dart-lang) 2013/08/21 20:35:42 unfortunatelly I need the 'document' argument both
+ .then((_) => elements.addAll(document.queryAll('polymer-element')));
+ });
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698