Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Issue 22825003: roll gyp 1682:1693 (Closed)

Created:
7 years, 4 months ago by Nico
Modified:
7 years, 4 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

roll gyp 1682:1693 The big change is initial support for ARCHS / fat binaries with ninja on mac. 1683: On Windows, don't try to create relative paths across different drives 1684: Fix typo in r1683. 1685: ninja/mac: GCC_C_LANGUAGE_STANDARD ansi is -ansi, not -std=ansi 1686: ninja/mac: Simplify slightly, no behavior change 1687: ninja/mac: Don't write emtpy postbuild variable for non-bundle links. 1688: ninja: Reduce scope of a variable, no behavior change 1689: ninja: Give WriteSources() and WriteLink() an explicit ninja_file parameter. 1690: ninja: Let WriteLink() return the linked binary, no behavior change. 1691: Linux: make ninja respect environment: CFLAGS, CXXFLAGS, LDFLAGS 1692: ninja/mac: Support multi-arch builds via ARCHS 1693: ninja/mac: Warn on conditional keys. BUG=90185 TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217040

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
7 years, 4 months ago (2013-08-12 15:58:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/22825003/1
7 years, 4 months ago (2013-08-12 15:58:51 UTC) #2
scottmg
lgtm
7 years, 4 months ago (2013-08-12 16:23:44 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 18:10:31 UTC) #4
Message was sent while issue was closed.
Change committed as 217040

Powered by Google App Engine
This is Rietveld 408576698