Issue 22824005: On Windows, the return value of socket() should be compared with

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22824005: On Windows, the return value of socket() should be compared with (Closed)

Created:
7 years, 4 months ago by wtc

Modified:
7 years, 4 months ago

Reviewers:
Ryan Sleevi

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

On Windows, the return value of socket() should be compared with INVALID_SOCKET for failure. R=rsleevi@chromium.org BUG=271530 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217101

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	net/socket/tcp_server_socket_win.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

wtc

https://codereview.chromium.org/22824005/diff/1/net/socket/tcp_server_socket_win.cc File net/socket/tcp_server_socket_win.cc (right): https://codereview.chromium.org/22824005/diff/1/net/socket/tcp_server_socket_win.cc#newcode48 net/socket/tcp_server_socket_win.cc:48: if (socket_ == INVALID_SOCKET) { See the "Return value" ...

7 years, 4 months ago (2013-08-12 17:31:30 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/22824005/1

7 years, 4 months ago (2013-08-12 17:44:04 UTC) #3

Message was sent while issue was closed.

Change committed as 217101

Expand Messages | Collapse Messages