Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 22824003: Eliminate Smi check when changing from Smi to Integer32 (Closed) Base URL: https://github.com/v8/v8.git@master
Patch Set: rebase to latest source Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1809 matching lines...) Expand 10 before | Expand all | Expand 10 after
1820 return AssignEnvironment(DefineAsRegister(res)); 1820 return AssignEnvironment(DefineAsRegister(res));
1821 } else if (to.IsSmi()) { 1821 } else if (to.IsSmi()) {
1822 HValue* val = instr->value(); 1822 HValue* val = instr->value();
1823 LOperand* value = UseRegister(val); 1823 LOperand* value = UseRegister(val);
1824 if (val->type().IsSmi()) { 1824 if (val->type().IsSmi()) {
1825 return DefineSameAsFirst(new(zone()) LDummyUse(value)); 1825 return DefineSameAsFirst(new(zone()) LDummyUse(value));
1826 } 1826 }
1827 return AssignEnvironment(DefineSameAsFirst(new(zone()) LCheckSmi(value))); 1827 return AssignEnvironment(DefineSameAsFirst(new(zone()) LCheckSmi(value)));
1828 } else { 1828 } else {
1829 ASSERT(to.IsInteger32()); 1829 ASSERT(to.IsInteger32());
1830 LOperand* value = UseRegister(instr->value()); 1830 HValue* val = instr->value();
1831 if (instr->value()->type().IsSmi()) { 1831 LOperand* value = UseRegister(val);
1832 if (val->type().IsSmi() || val->representation().IsSmi()) {
1832 return DefineSameAsFirst(new(zone()) LSmiUntag(value, false)); 1833 return DefineSameAsFirst(new(zone()) LSmiUntag(value, false));
1833 } else { 1834 } else {
1834 bool truncating = instr->CanTruncateToInt32(); 1835 bool truncating = instr->CanTruncateToInt32();
1835 LOperand* xmm_temp = truncating ? NULL : FixedTemp(xmm1); 1836 LOperand* xmm_temp = truncating ? NULL : FixedTemp(xmm1);
1836 LTaggedToI* res = new(zone()) LTaggedToI(value, xmm_temp); 1837 LTaggedToI* res = new(zone()) LTaggedToI(value, xmm_temp);
1837 return AssignEnvironment(DefineSameAsFirst(res)); 1838 return AssignEnvironment(DefineSameAsFirst(res));
1838 } 1839 }
1839 } 1840 }
1840 } else if (from.IsDouble()) { 1841 } else if (from.IsDouble()) {
1841 if (to.IsTagged()) { 1842 if (to.IsTagged()) {
(...skipping 674 matching lines...) Expand 10 before | Expand all | Expand 10 after
2516 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2517 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2517 LOperand* object = UseRegister(instr->object()); 2518 LOperand* object = UseRegister(instr->object());
2518 LOperand* index = UseTempRegister(instr->index()); 2519 LOperand* index = UseTempRegister(instr->index());
2519 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2520 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2520 } 2521 }
2521 2522
2522 2523
2523 } } // namespace v8::internal 2524 } } // namespace v8::internal
2524 2525
2525 #endif // V8_TARGET_ARCH_X64 2526 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698