Issue 22824002: Better fix for a redundant call to Reattach in RenderViewDevToolsAgentHost::ConnectRenderViewHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22824002: Better fix for a redundant call to Reattach in RenderViewDevToolsAgentHost::ConnectRenderViewHost (Closed)

Created:
7 years, 4 months ago by Vladislav Kaznacheev

Modified:
7 years, 4 months ago

Reviewers:
pfeldman

CC:
chromium-reviews, vsevik, jam, yurys, joi+watch-content_chromium.org, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman, Peter.Rybin

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Better fix for a redundant call to Reattach in RenderViewDevToolsAgentHost::ConnectRenderViewHost A previous fix (https://chromiumcodereview.appspot.com/22674008/) regressed the behaviour of RVDTAH on navigation. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217047

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	content/browser/devtools/render_view_devtools_agent_host.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/22824002/1

7 years, 4 months ago (2013-08-12 13:13:41 UTC) #3

Message was sent while issue was closed.

Change committed as 217047

Expand Messages | Collapse Messages