Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: content/browser/geolocation/gps_location_provider_linux.h

Issue 22821002: Delete todo to add threading in GpsLocationProviderLinux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/geolocation/gps_location_provider_linux.h
diff --git a/content/browser/geolocation/gps_location_provider_linux.h b/content/browser/geolocation/gps_location_provider_linux.h
index 722baf45d94f43d3f9c1febe4584122d3b56aee4..76589379641fcb8ad718025ea5d4328a994f2721 100644
--- a/content/browser/geolocation/gps_location_provider_linux.h
+++ b/content/browser/geolocation/gps_location_provider_linux.h
@@ -56,10 +56,6 @@ class CONTENT_EXPORT LibGps {
};
// Location provider for Linux, that uses libgps/gpsd to obtain position fixes.
-// TODO(joth): Currently this runs entirely in the client thread (i.e. Chrome's
-// IO thread). As the older libgps API is not designed to support polling,
-// there's a chance it could block, so better move this into its own worker
-// thread.
class CONTENT_EXPORT GpsLocationProviderLinux : public LocationProviderBase {
public:
typedef LibGps* (*LibGpsFactory)();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698