Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1460)

Unified Diff: runtime/observatory/lib/src/elements/eval_box.dart

Issue 2281903003: Added quicks support to Observatory eval-box element (Closed)
Patch Set: Renamed quicks in quickExpressions Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/eval_box.dart
diff --git a/runtime/observatory/lib/src/elements/eval_box.dart b/runtime/observatory/lib/src/elements/eval_box.dart
index e01465a558fbe176ab9e761c6afa398fc12ffd05..004d9e041fc0f56fdf377f4d191291d8a28d6ab1 100644
--- a/runtime/observatory/lib/src/elements/eval_box.dart
+++ b/runtime/observatory/lib/src/elements/eval_box.dart
@@ -29,6 +29,7 @@ class EvalBoxElement extends HtmlElement implements Renderable {
final _results = <_ExpressionDescription>[];
String _expression = '';
bool _multiline;
+ Iterable<String> _quickExpressions;
M.IsolateRef get isolate => _isolate;
M.ObjectRef get context => _context;
@@ -36,12 +37,15 @@ class EvalBoxElement extends HtmlElement implements Renderable {
factory EvalBoxElement(M.IsolateRef isolate, M.ObjectRef context,
M.InstanceRepository instances,
M.EvalRepository eval,
- {bool multiline: false, RenderingQueue queue}) {
+ {bool multiline: false,
+ Iterable<String> quickExpressions: const [],
+ RenderingQueue queue}) {
assert(isolate != null);
assert(context != null);
assert(instances != null);
assert(eval != null);
assert(multiline != null);
+ assert(quickExpressions != null);
EvalBoxElement e = document.createElement(tag.name);
e._r = new RenderingScheduler(e, queue: queue);
e._isolate = isolate;
@@ -49,6 +53,7 @@ class EvalBoxElement extends HtmlElement implements Renderable {
e._instances = instances;
e._eval = eval;
e._multiline = multiline;
+ e._quickExpressions = new List.unmodifiable(quickExpressions);
return e;
}
@@ -70,6 +75,15 @@ class EvalBoxElement extends HtmlElement implements Renderable {
void render() {
children = [
+ new DivElement()..classes = const ['quicks']
+ ..children = _quickExpressions.map((q) =>
+ new ButtonElement()
+ ..text = q
+ ..onClick.listen((_) {
+ _expression = q;
+ _run();
+ })
+ ),
new DivElement()..classes = const ['heading']
..children = [
new FormElement()
« no previous file with comments | « runtime/observatory/lib/src/elements/css/shared.css ('k') | runtime/observatory/lib/src/elements/eval_box_wrapper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698