Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 22813002: [SyncFS] Rename kind() to file_kind (Closed)

Created:
7 years, 4 months ago by tzik
Modified:
7 years, 4 months ago
Reviewers:
kinuko
CC:
chromium-reviews, nhiroki+watch_chromium.org, tzik+watch_chromium.org, kinuko+watch
Visibility:
Public.

Description

[SyncFS] Rename kind() to file_kind. Refactoring change. This field has similar name to a field that I'm going to add. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216972

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M chrome/browser/sync_file_system/drive_backend/metadata_database.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database.proto View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tzik
PTAL. This is a preparation of adding TrackerKind, which I'm going to add. FileKind enum ...
7 years, 4 months ago (2013-08-12 10:18:33 UTC) #1
kinuko
lgtm
7 years, 4 months ago (2013-08-12 10:30:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/22813002/1
7 years, 4 months ago (2013-08-12 11:25:42 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 11:26:01 UTC) #4
Message was sent while issue was closed.
Change committed as 216972

Powered by Google App Engine
This is Rietveld 408576698