Issue 22812004: Set encoding properly in make_token_matcher.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22812004: Set encoding properly in make_token_matcher.py (Closed)

Created:
7 years, 4 months ago by dvh

Modified:
7 years, 4 months ago

Reviewers:
eseidel

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

io.open() will fail on Mac when no encoding is passed as parameter. It will make the build of chromium fail. This patch will set the encoding to utf-8. BUG=271567 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156250

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/core/scripts/make_token_matcher.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dvh@chromium.org/22812004/1

7 years, 4 months ago (2013-08-16 22:18:41 UTC) #3

Message was sent while issue was closed.

Change committed as 156250