Moved chrome/common/json_schema to components/json_schema.

Moved chrome/common/json_schema to components/json_schema.

BUG=271392
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217364

[Joao da Silva, 2013-08-12 15:34:00]

Please have a look:

@Jochen: gyp & chrome/ changes

@Benjamin: moved files, esp. the update to
json_schema_validator_unittest_base.cc

Thanks!

[not at google - send to devlin, 2013-08-12 19:36:45]

lgtm

[jochen (gone - plz use gerrit), 2013-08-12 19:37:32]

lgtm

[Joao da Silva, 2013-08-13 09:39:28]

Please have a look:

@ Benjamin: the whole thing, again :-)

@ Jói: please review the new component


//chrome/common/json_schema is being moved to a new component because it's a
dependency of //chrome/browser/policy, which will also move into a new
component.

json_schema was initially moved to //extensions/common, but unfortunately that
code is included in the chrome.gyp:common target, and components can't depend on
that.

This code could also be moved to //base/json but it's not widely used at this
stage to justify that move; I think the current CL is the most appropriate move
for now but I'm open to other ideas.

[Jói, 2013-08-13 09:46:52]

I looked at all files under //components.  There is one simple thing to take
care of and then you're good to go.

Cheers,
Jói

https://codereview.chromium.org/22807004/diff/13002/components/json_schema/js...
File components/json_schema/json_schema_validator_unittest_base.cc (right):

https://codereview.chromium.org/22807004/diff/13002/components/json_schema/js...
components/json_schema/json_schema_validator_unittest_base.cc:31: path =
path.AppendASCII("chrome")
The test data should move from //chrome/test/data to //components/test/data, and
this path should be updated to match that.

[Joao da Silva, 2013-08-13 11:34:02]

Thanks for the input Jói! Test data moved, ready for another look.

https://codereview.chromium.org/22807004/diff/13002/components/json_schema/js...
File components/json_schema/json_schema_validator_unittest_base.cc (right):

https://codereview.chromium.org/22807004/diff/13002/components/json_schema/js...
components/json_schema/json_schema_validator_unittest_base.cc:31: path =
path.AppendASCII("chrome")
On 2013/08/13 09:46:52, Jói wrote:
> The test data should move from //chrome/test/data to //components/test/data,
and
> this path should be updated to match that.

Done.

[Jói, 2013-08-13 11:46:09]

//components LGTM.

[Joao da Silva, 2013-08-13 18:55:33]

Benjamin, I'll land this if you agree with the new location of json_schema.

PTAL, thanks!

[not at google - send to devlin, 2013-08-13 18:57:32]

Oh; we just moved it all to components? I... guess that's ok, though you don't
need my lg anymore.

[Joao da Silva, 2013-08-13 19:02:28]

You don't sound very convinced :-)

Other suggestions are welcome, as long as the new location can be #included by
components.

I'll send this to the CQ for now to unblock further work on our side, but I'm
happy to move it to a location that makes more sense if there's one.

[not at google - send to devlin, 2013-08-13 19:07:13]

oh I'm no more convinced than it should be in extensions. components/ lgtm.

[not at google - send to devlin, 2013-08-13 19:07:47]

which is to say, I really don't mind

[commit-bot: I haz the power, 2013-08-13 19:20:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/22807004/52001

[commit-bot: I haz the power, 2013-08-13 22:55:12]

Change committed as 217364