Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 22802005: [Android] Extend proguard preprocessing to prebuilt Java libraries. (Closed)

Created:
7 years, 4 months ago by aruslan
Modified:
7 years, 4 months ago
Reviewers:
cjhopman
CC:
chromium-reviews
Visibility:
Public.

Description

[Android] Extend proguard preprocessing to prebuilt Java libraries. * Adds support for running proguard on prebuilt libraries before they are added to the final release APK. BUG=272790 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218353

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -3 lines) Patch
M build/java_prebuilt.gypi View 1 2 3 3 chunks +52 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
aruslan
hi Chris, PTAL, thanks! Feel free to add anyone you see fit.
7 years, 4 months ago (2013-08-16 22:55:58 UTC) #1
cjhopman
lgtm https://codereview.chromium.org/22802005/diff/7001/build/java_prebuilt.gypi File build/java_prebuilt.gypi (right): https://codereview.chromium.org/22802005/diff/7001/build/java_prebuilt.gypi#newcode74 build/java_prebuilt.gypi:74: '--classpath=<(android_sdk_jar) >(input_jars_paths)', change to just: '--classpath=>(input_jars_paths)',
7 years, 4 months ago (2013-08-16 23:03:06 UTC) #2
aruslan
Thanks, Chris! https://codereview.chromium.org/22802005/diff/7001/build/java_prebuilt.gypi File build/java_prebuilt.gypi (right): https://codereview.chromium.org/22802005/diff/7001/build/java_prebuilt.gypi#newcode74 build/java_prebuilt.gypi:74: '--classpath=<(android_sdk_jar) >(input_jars_paths)', On 2013/08/16 23:03:06, cjhopman wrote: ...
7 years, 4 months ago (2013-08-19 17:12:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/22802005/12001
7 years, 4 months ago (2013-08-19 22:39:13 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-19 22:45:45 UTC) #5
Message was sent while issue was closed.
Change committed as 218353

Powered by Google App Engine
This is Rietveld 408576698