Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 22797008: Force delegated renderer on Aura (Closed)

Created:
7 years, 4 months ago by piman
Modified:
7 years, 3 months ago
Reviewers:
danakj, Zhenyao Mo, lazyboy
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Force delegated renderer on Aura BUG=123444 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220638

Patch Set 1 #

Patch Set 2 : (on top of 22912014) #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase, fix or disable tests #

Patch Set 6 : rebase, flaky test #

Patch Set 7 : rebase, fix flakiness #

Total comments: 4

Patch Set 8 : Add log #

Patch Set 9 : fix whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -5 lines) Patch
M chrome/browser/apps/web_view_browsertest.cc View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/apps/web_view_interactive_browsertest.cc View 1 2 3 4 5 6 4 chunks +13 lines, -4 lines 0 comments Download
M chrome/test/gpu/gpu_feature_browsertest.cc View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/browser_plugin/browser_plugin_host_browsertest.cc View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/gpu/compositor_util.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/gpu/compositor_util.cc View 1 2 3 4 5 6 7 8 1 chunk +24 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
piman
danakj: please review lazyboy: OWNERS for web_view_* tests zmo: OWNERS for gpu_feature_browsertest.cc
7 years, 3 months ago (2013-08-30 00:01:57 UTC) #1
danakj
LGTM https://chromiumcodereview.appspot.com/22797008/diff/45001/content/browser/gpu/compositor_util.cc File content/browser/gpu/compositor_util.cc (right): https://chromiumcodereview.appspot.com/22797008/diff/45001/content/browser/gpu/compositor_util.cc#newcode109 content/browser/gpu/compositor_util.cc:109: #if defined(USE_AURA) nit: space above this. https://chromiumcodereview.appspot.com/22797008/diff/45001/content/browser/gpu/compositor_util.cc#newcode119 content/browser/gpu/compositor_util.cc:119: ...
7 years, 3 months ago (2013-08-30 00:10:08 UTC) #2
Zhenyao Mo
On 2013/08/30 00:10:08, danakj wrote: > LGTM > > https://chromiumcodereview.appspot.com/22797008/diff/45001/content/browser/gpu/compositor_util.cc > File content/browser/gpu/compositor_util.cc (right): > ...
7 years, 3 months ago (2013-08-30 00:40:47 UTC) #3
piman
https://chromiumcodereview.appspot.com/22797008/diff/45001/content/browser/gpu/compositor_util.cc File content/browser/gpu/compositor_util.cc (right): https://chromiumcodereview.appspot.com/22797008/diff/45001/content/browser/gpu/compositor_util.cc#newcode109 content/browser/gpu/compositor_util.cc:109: #if defined(USE_AURA) On 2013/08/30 00:10:08, danakj wrote: > nit: ...
7 years, 3 months ago (2013-08-30 04:01:20 UTC) #4
danakj
Thanks! Lgtmstill
7 years, 3 months ago (2013-08-30 05:55:19 UTC) #5
lazyboy
lgtm
7 years, 3 months ago (2013-08-30 13:39:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/22797008/55001
7 years, 3 months ago (2013-08-30 17:16:22 UTC) #7
commit-bot: I haz the power
Change committed as 220638
7 years, 3 months ago (2013-08-30 20:25:58 UTC) #8
Ryan Hamilton
On 2013/08/30 20:25:58, I haz the power (commit-bot) wrote: > Change committed as 220638 It ...
7 years, 3 months ago (2013-09-01 16:10:45 UTC) #9
danakj
7 years, 3 months ago (2013-09-05 20:04:58 UTC) #10
Message was sent while issue was closed.
On 2013/09/01 16:10:45, Ryan Hamilton wrote:
> On 2013/08/30 20:25:58, I haz the power (commit-bot) wrote:
> > Change committed as 220638
> 
> It looks like the tree has been closed since this change landed. 
> 
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%25...
> 
> BrowserPluginHostTest.EmbedderSameAfterNav is failing.  Here's a link to a
> failing build:
> 
>
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%252...
> 
> I suspect this change is the culprit.  Can you comment?

Working on this here: https://code.google.com/p/chromium/issues/detail?id=283625

Powered by Google App Engine
This is Rietveld 408576698