Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 22796009: Shrink trace_event buffers (Closed)

Created:
7 years, 4 months ago by Xianzhu
Modified:
7 years, 4 months ago
Reviewers:
dsinclair, nduca
CC:
chromium-reviews, dsinclair+watch_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Shrink trace_event buffers The original 500000 is way too big. Shrink non-ring-buffer by 1/2 and ring-buffer to 1/4 of non-ring-buffer. Tests showed that for a busy app with impl-side-painting enabled, the shrunk ring buffer can contain about 3-5 seconds of trace. The time will double after we switch to X event for B/E events. BUG=248022 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218119

Patch Set 1 #

Patch Set 2 : Shrink non-ring-buffer also #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -10 lines) Patch
base/debug/trace_event_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/debug/trace_event_impl.cc View 1 7 chunks +23 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Xianzhu
7 years, 4 months ago (2013-08-16 18:13:51 UTC) #1
dsinclair
Do we want to reduce the non-ring buffer size as well? We're going to hit ...
7 years, 4 months ago (2013-08-16 19:04:41 UTC) #2
Xianzhu
On 2013/08/16 19:04:41, dsinclair wrote: > Do we want to reduce the non-ring buffer size ...
7 years, 4 months ago (2013-08-16 19:17:50 UTC) #3
nduca
LGTM but lets reduce the non-ring-buffer by 1/2 just because its way too big right ...
7 years, 4 months ago (2013-08-16 19:31:02 UTC) #4
Xianzhu
On 2013/08/16 19:31:02, nduca wrote: > LGTM but lets reduce the non-ring-buffer by 1/2 just ...
7 years, 4 months ago (2013-08-16 19:47:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/22796009/4002
7 years, 4 months ago (2013-08-16 19:58:24 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-16 23:26:09 UTC) #7
Message was sent while issue was closed.
Change committed as 218119

Powered by Google App Engine
This is Rietveld 408576698