Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 22796002: Check if the theme supplier is an extension. (Closed)

Created:
7 years, 4 months ago by Adrian Kuegel
Modified:
7 years, 4 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews
Visibility:
Public.

Description

Check if the theme supplier is an extension. On linux aura, a supervised user may get the native theme as default theme, which is also represented by a CustomThemeSupplier. When checking if a custom theme is already installed we therefore need to check if it is an extension type. BUG=265387 TEST=Create a supervised user on linux aura and check if it gets the managed user theme. TBR=pkotwicz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217046

Patch Set 1 : Check theme type. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/themes/theme_service.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Adrian Kuegel
Hi Peter, I hope it is ok that I TBR you on this change. I ...
7 years, 4 months ago (2013-08-12 08:58:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/22796002/3001
7 years, 4 months ago (2013-08-12 08:59:30 UTC) #2
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 19:07:13 UTC) #3
Message was sent while issue was closed.
Change committed as 217046

Powered by Google App Engine
This is Rietveld 408576698