Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: net/url_request/url_request_file_job.cc

Issue 22795006: Remove WorkerPool dependency from URLRequestFileJob. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix build Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/url_request/url_request_file_job.h ('k') | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // For loading files, we make use of overlapped i/o to ensure that reading from 5 // For loading files, we make use of overlapped i/o to ensure that reading from
6 // the filesystem (e.g., a network filesystem) does not block the calling 6 // the filesystem (e.g., a network filesystem) does not block the calling
7 // thread. An alternative approach would be to use a background thread or pool 7 // thread. An alternative approach would be to use a background thread or pool
8 // of threads, but it seems better to leverage the operating system's ability 8 // of threads, but it seems better to leverage the operating system's ability
9 // to do background file reads for us. 9 // to do background file reads for us.
10 // 10 //
11 // Since overlapped reads require a 'static' buffer for the duration of the 11 // Since overlapped reads require a 'static' buffer for the duration of the
12 // asynchronous read, the URLRequestFileJob keeps a buffer as a member var. In 12 // asynchronous read, the URLRequestFileJob keeps a buffer as a member var. In
13 // URLRequestFileJob::Read, data is simply copied from the object's buffer into 13 // URLRequestFileJob::Read, data is simply copied from the object's buffer into
14 // the given buffer. If there is no data to copy, the URLRequestFileJob 14 // the given buffer. If there is no data to copy, the URLRequestFileJob
15 // attempts to read more from the file to fill its buffer. If reading from the 15 // attempts to read more from the file to fill its buffer. If reading from the
16 // file does not complete synchronously, then the URLRequestFileJob waits for a 16 // file does not complete synchronously, then the URLRequestFileJob waits for a
17 // signal from the OS that the overlapped read has completed. It does so by 17 // signal from the OS that the overlapped read has completed. It does so by
18 // leveraging the MessageLoop::WatchObject API. 18 // leveraging the MessageLoop::WatchObject API.
19 19
20 #include "net/url_request/url_request_file_job.h" 20 #include "net/url_request/url_request_file_job.h"
21 21
22 #include "base/bind.h" 22 #include "base/bind.h"
23 #include "base/compiler_specific.h" 23 #include "base/compiler_specific.h"
24 #include "base/file_util.h" 24 #include "base/file_util.h"
25 #include "base/message_loop/message_loop.h" 25 #include "base/message_loop/message_loop.h"
26 #include "base/platform_file.h" 26 #include "base/platform_file.h"
27 #include "base/strings/string_util.h" 27 #include "base/strings/string_util.h"
28 #include "base/synchronization/lock.h" 28 #include "base/synchronization/lock.h"
29 #include "base/task_runner.h"
29 #include "base/threading/thread_restrictions.h" 30 #include "base/threading/thread_restrictions.h"
30 #include "base/threading/worker_pool.h"
31 #include "build/build_config.h" 31 #include "build/build_config.h"
32 #include "net/base/file_stream.h" 32 #include "net/base/file_stream.h"
33 #include "net/base/io_buffer.h" 33 #include "net/base/io_buffer.h"
34 #include "net/base/load_flags.h" 34 #include "net/base/load_flags.h"
35 #include "net/base/mime_util.h" 35 #include "net/base/mime_util.h"
36 #include "net/base/net_errors.h" 36 #include "net/base/net_errors.h"
37 #include "net/base/net_util.h" 37 #include "net/base/net_util.h"
38 #include "net/http/http_util.h" 38 #include "net/http/http_util.h"
39 #include "net/url_request/url_request_error_job.h" 39 #include "net/url_request/url_request_error_job.h"
40 #include "net/url_request/url_request_file_dir_job.h" 40 #include "net/url_request/url_request_file_dir_job.h"
41 #include "url/gurl.h" 41 #include "url/gurl.h"
42 42
43 #if defined(OS_WIN) 43 #if defined(OS_WIN)
44 #include "base/win/shortcut.h" 44 #include "base/win/shortcut.h"
45 #endif 45 #endif
46 46
47 namespace net { 47 namespace net {
48 48
49 URLRequestFileJob::FileMetaInfo::FileMetaInfo() 49 URLRequestFileJob::FileMetaInfo::FileMetaInfo()
50 : file_size(0), 50 : file_size(0),
51 mime_type_result(false), 51 mime_type_result(false),
52 file_exists(false), 52 file_exists(false),
53 is_directory(false) { 53 is_directory(false) {
54 } 54 }
55 55
56 URLRequestFileJob::URLRequestFileJob(URLRequest* request, 56 URLRequestFileJob::URLRequestFileJob(
57 NetworkDelegate* network_delegate, 57 URLRequest* request,
58 const base::FilePath& file_path) 58 NetworkDelegate* network_delegate,
59 const base::FilePath& file_path,
60 const scoped_refptr<base::TaskRunner>& file_task_runner)
59 : URLRequestJob(request, network_delegate), 61 : URLRequestJob(request, network_delegate),
60 file_path_(file_path), 62 file_path_(file_path),
61 stream_(new FileStream(NULL)), 63 stream_(new FileStream(NULL, file_task_runner)),
64 file_task_runner_(file_task_runner),
62 remaining_bytes_(0), 65 remaining_bytes_(0),
63 weak_ptr_factory_(this) { 66 weak_ptr_factory_(this) {}
64 }
65 67
66 void URLRequestFileJob::Start() { 68 void URLRequestFileJob::Start() {
67 FileMetaInfo* meta_info = new FileMetaInfo(); 69 FileMetaInfo* meta_info = new FileMetaInfo();
68 base::WorkerPool::PostTaskAndReply( 70 file_task_runner_->PostTaskAndReply(
69 FROM_HERE, 71 FROM_HERE,
70 base::Bind(&URLRequestFileJob::FetchMetaInfo, file_path_, 72 base::Bind(&URLRequestFileJob::FetchMetaInfo, file_path_,
71 base::Unretained(meta_info)), 73 base::Unretained(meta_info)),
72 base::Bind(&URLRequestFileJob::DidFetchMetaInfo, 74 base::Bind(&URLRequestFileJob::DidFetchMetaInfo,
73 weak_ptr_factory_.GetWeakPtr(), 75 weak_ptr_factory_.GetWeakPtr(),
74 base::Owned(meta_info)), 76 base::Owned(meta_info)));
75 true);
76 } 77 }
77 78
78 void URLRequestFileJob::Kill() { 79 void URLRequestFileJob::Kill() {
79 stream_.reset(); 80 stream_.reset();
80 weak_ptr_factory_.InvalidateWeakPtrs(); 81 weak_ptr_factory_.InvalidateWeakPtrs();
81 82
82 URLRequestJob::Kill(); 83 URLRequestJob::Kill();
83 } 84 }
84 85
85 bool URLRequestFileJob::ReadRawData(IOBuffer* dest, int dest_size, 86 bool URLRequestFileJob::ReadRawData(IOBuffer* dest, int dest_size,
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 NotifyDone(URLRequestStatus(URLRequestStatus::FAILED, result)); 292 NotifyDone(URLRequestStatus(URLRequestStatus::FAILED, result));
292 } 293 }
293 294
294 remaining_bytes_ -= result; 295 remaining_bytes_ -= result;
295 DCHECK_GE(remaining_bytes_, 0); 296 DCHECK_GE(remaining_bytes_, 0);
296 297
297 NotifyReadComplete(result); 298 NotifyReadComplete(result);
298 } 299 }
299 300
300 } // namespace net 301 } // namespace net
OLDNEW
« no previous file with comments | « net/url_request/url_request_file_job.h ('k') | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698