Remove deprecated functions that take StreamSockets instead of handles

Remove deprecated functions that take StreamSockets instead of handles

BUG=37810
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217433

[akalin, 2013-08-13 19:34:32]

+sleevi for review
+sergeyu for remoting/ OWNERS

[Sergey Ulanov, 2013-08-13 19:40:51]

remoting - LGTM

[Ryan Sleevi, 2013-08-13 20:26:12]

Looks like you still have some unittest code to clean up?

https://codereview.chromium.org/22794008/diff/1/net/socket/socks5_client_sock...
File net/socket/socks5_client_socket_unittest.cc (right):

https://codereview.chromium.org/22794008/diff/1/net/socket/socks5_client_sock...
net/socket/socks5_client_socket_unittest.cc:101: // non-owning pointer to it.
comment nit: s/we still//

https://groups.google.com/a/chromium.org/d/msg/chromium-dev/NH-S6KCkr2M/yv0z3...

https://codereview.chromium.org/22794008/diff/1/net/socket/socks5_client_sock...
net/socket/socks5_client_socket_unittest.cc:103: return new
SOCKS5ClientSocket(connection.release(),
style nit: connection.release() should be on a newline

https://codereview.chromium.org/22794008/diff/1/net/socket/socks_client_socke...
File net/socket/socks_client_socket_unittest.cc (right):

https://codereview.chromium.org/22794008/diff/1/net/socket/socks_client_socke...
net/socket/socks_client_socket_unittest.cc:80: // non-owning pointer to it.
same comment nit: s/we still//

https://groups.google.com/a/chromium.org/d/msg/chromium-dev/NH-S6KCkr2M/yv0z3...

https://codereview.chromium.org/22794008/diff/1/net/socket/socks_client_socke...
net/socket/socks_client_socket_unittest.cc:82: return new
SOCKSClientSocket(connection.release(),
same style nit: linebreak

https://codereview.chromium.org/22794008/diff/1/net/socket_stream/socket_stre...
File net/socket_stream/socket_stream.cc (right):

https://codereview.chromium.org/22794008/diff/1/net/socket_stream/socket_stre...
net/socket_stream/socket_stream.cc:967: connection.release(), req_info,
context_->host_resolver()));
seems like this could be

socket_.reset(new SOCKSClientSocket(
    connection.release(), req_info, context_->host_resolver()));

[akalin, 2013-08-13 20:51:27]

PTAL!

https://codereview.chromium.org/22794008/diff/1/net/socket/socks5_client_sock...
File net/socket/socks5_client_socket_unittest.cc (right):

https://codereview.chromium.org/22794008/diff/1/net/socket/socks5_client_sock...
net/socket/socks5_client_socket_unittest.cc:101: // non-owning pointer to it.
On 2013/08/13 20:26:13, Ryan Sleevi wrote:
> comment nit: s/we still//
> 
>
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/NH-S6KCkr2M/yv0z3...

Done.

https://codereview.chromium.org/22794008/diff/1/net/socket/socks5_client_sock...
net/socket/socks5_client_socket_unittest.cc:103: return new
SOCKS5ClientSocket(connection.release(),
On 2013/08/13 20:26:13, Ryan Sleevi wrote:
> style nit: connection.release() should be on a newline

Done.

https://codereview.chromium.org/22794008/diff/1/net/socket/socks_client_socke...
File net/socket/socks_client_socket_unittest.cc (right):

https://codereview.chromium.org/22794008/diff/1/net/socket/socks_client_socke...
net/socket/socks_client_socket_unittest.cc:80: // non-owning pointer to it.
On 2013/08/13 20:26:13, Ryan Sleevi wrote:
> same comment nit: s/we still//
> 
>
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/NH-S6KCkr2M/yv0z3...

Done.

https://codereview.chromium.org/22794008/diff/1/net/socket/socks_client_socke...
net/socket/socks_client_socket_unittest.cc:82: return new
SOCKSClientSocket(connection.release(),
On 2013/08/13 20:26:13, Ryan Sleevi wrote:
> same style nit: linebreak

Done.

https://codereview.chromium.org/22794008/diff/1/net/socket_stream/socket_stre...
File net/socket_stream/socket_stream.cc (right):

https://codereview.chromium.org/22794008/diff/1/net/socket_stream/socket_stre...
net/socket_stream/socket_stream.cc:967: connection.release(), req_info,
context_->host_resolver()));
On 2013/08/13 20:26:13, Ryan Sleevi wrote:
> seems like this could be
> 
> socket_.reset(new SOCKSClientSocket(
>     connection.release(), req_info, context_->host_resolver()));

Done.

[Ryan Sleevi, 2013-08-13 21:03:13]

lgtm

[commit-bot: I haz the power, 2013-08-13 21:18:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/22794008/21001

[commit-bot: I haz the power, 2013-08-14 01:43:23]

Change committed as 217433