Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 22794002: Support inputmode using InputScope for Windows8 desktop. (Closed)

Created:
7 years, 4 months ago by yoichio
Modified:
7 years, 3 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Support inputmode using InputScope for Windows8 desktop. ImmSetConversionStatus doesn't work on Windows8: http://msdn.microsoft.com/en-us/library/windows/desktop/hh994466.aspx So we need to use InputScope to tell IME conversion modes(Hiragana, Katakana..). BUG=244688 TEST=manually done with windows8 desktop using hardware keyboard and onscreen keyboard. Both MS-IME and GoogleJapaneseInput works with hardware keyboard. Unfortunately, onscreen keyboard with MS-IME doesn't work but with GoogleJapaneseIME works. I wrote another CL to implement setting target InputScope(IS_KANA, IS_KATAKANA_FULLWIDTH and IS_ALPHANUMERIC_FULLWIDTH) using COM interface, which is ITextStoreACP::RetrieveRequestedAttrs. http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/ime/win/tsf_text_store.cc And try "chrome --enable-text-services-framework" on Windows8 desktop. I found that 1. Both MS-IME and GoogleJapaneseInput work fine (changing conversion mode "kana", "katakana" and "full-width-latin") with hardware keyboard input. 2. With onscreen keyboard, GoogleJapaneseInput works but MS-IME doesn't. This behavior is same as this CL's try. Additionally, I try to use CSS ime-mode property with IE10. http://msdn.microsoft.com/en-us/library/ff521067.aspx ime-mode property also sets IME status simply ON/OFF. I got same result to above. So using IMEs with hardware keyboard works but only onscreenkeyboard-MSIME pair fails. In my conclusion, Windows8 onscreen keyboard with MS-IME takes a somewhat wrong with InputScope. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220221

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
yoichio
7 years, 4 months ago (2013-08-21 07:26:36 UTC) #1
Yohei Yukawa
On 2013/08/21 07:26:36, yoichio wrote: > MS-IME onscreen keyboard looks not supporting to switch conversion ...
7 years, 4 months ago (2013-08-21 08:44:32 UTC) #2
yoichio
On 2013/08/21 08:44:32, Yohei Yukawa wrote: > On 2013/08/21 07:26:36, yoichio wrote: > > > ...
7 years, 3 months ago (2013-08-26 04:50:41 UTC) #3
Yohei Yukawa
On 2013/08/26 04:50:41, yoichio wrote: > On 2013/08/21 08:44:32, Yohei Yukawa wrote: > > On ...
7 years, 3 months ago (2013-08-26 05:21:30 UTC) #4
yoichio
On 2013/08/26 05:21:30, Yohei Yukawa wrote: > On 2013/08/26 04:50:41, yoichio wrote: > > On ...
7 years, 3 months ago (2013-08-27 03:54:35 UTC) #5
yoichio
On 2013/08/27 03:54:35, yoichio wrote: > On 2013/08/26 05:21:30, Yohei Yukawa wrote: > > On ...
7 years, 3 months ago (2013-08-27 08:39:27 UTC) #6
Yohei Yukawa
On 2013/08/27 08:39:27, yoichio wrote: > On 2013/08/27 03:54:35, yoichio wrote: > > On 2013/08/26 ...
7 years, 3 months ago (2013-08-27 16:11:58 UTC) #7
yoichio
Update description.
7 years, 3 months ago (2013-08-28 05:46:37 UTC) #8
Yohei Yukawa
lgtm with nits. Please remove "(v=vs.85)" from the URLs in your CL description.
7 years, 3 months ago (2013-08-28 06:44:49 UTC) #9
yoichio
Add sky@ as OWNER.
7 years, 3 months ago (2013-08-28 06:58:17 UTC) #10
sky
LGTM
7 years, 3 months ago (2013-08-28 13:51:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/22794002/3001
7 years, 3 months ago (2013-08-29 00:11:21 UTC) #12
yoichio
Thank for reviewing!
7 years, 3 months ago (2013-08-29 01:22:05 UTC) #13
commit-bot: I haz the power
7 years, 3 months ago (2013-08-29 08:47:57 UTC) #14
Message was sent while issue was closed.
Change committed as 220221

Powered by Google App Engine
This is Rietveld 408576698