DevTools: Add scripts for buildbot to use node.js/npm

DevTools: Add scripts for buildbot to use node.js/npm

I'm working on improving our build process so we can use npm modules
on buildbots (e.g. linting, type checking).

I copied these two python scripts from the infra team which will be used
by our buildbot recipe to install and run a local installation of node.js.

Original code here:
https://cs.chromium.org/chromium/infra/node/

BUG=642046
Committed: https://crrev.com/143336315cef6bf3f72826479af55a4f1f78c266
Cr-Commit-Position: refs/heads/master@{#415515}

[chenwilliam, 2016-08-25 20:41:09]

chenwilliam@chromium.org changed reviewers:
+ dgozman@chromium.org

[chenwilliam, 2016-08-25 20:41:10]

PTAL.

https://codereview.chromium.org/2278803004/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/package.json (right):

https://codereview.chromium.org/2278803004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/package.json:7: "lint": "eslint -c
front_end/.eslintrc.js --ignore-path front_end/.eslintignore front_end"
Eventually we can use this simple npm script instead of lint_javascript.py for
the presubmit hook, but for now I'll use this lint script because
lint_javascript.py is optional and passes when eslint is not installed.

[dgozman, 2016-08-26 19:08:05]

Let's have an issue with description of what we try to achieve here. This patch
on itself doesn't explain anything.

https://codereview.chromium.org/2278803004/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/scripts/nodejs/node.py (right):

https://codereview.chromium.org/2278803004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/scripts/nodejs/node.py:2: # Copyright (c)
2015 The Chromium Authors. All rights reserved.
new files should have new copyright: no (c), 2016

https://codereview.chromium.org/2278803004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/scripts/nodejs/node.py:7: # File originally
from https://cs.chromium.org/chromium/infra/node/node.py
Remove.

[chenwilliam, 2016-08-29 18:28:29]

Description was changed from

==========
DevTools: Add script to use local node.js and npm

I'm working on improving our build process so we can use npm modules
on buildbots (e.g. linting, type checking).

I copied these two python scripts from the infra team which allows us
to install and run a local installation of node.js.

Original code here:
https://cs.chromium.org/chromium/infra/node/

My next step is to create a buildbot recipe that will install node.js
and eslint and lints devtools commits.

BUG=none
==========

to

==========
DevTools: Add script to use local node.js and npm

I'm working on improving our build process so we can use npm modules
on buildbots (e.g. linting, type checking).

I copied these two python scripts from the infra team which allows us
to install and run a local installation of node.js.

Original code here:
https://cs.chromium.org/chromium/infra/node/

My next step is to create a buildbot recipe that will install node.js
and eslint and lints devtools commits.

BUG=642046
==========

[chenwilliam, 2016-08-29 18:42:27]

PTAL. I created a new ticket and attached it to the CL.

https://codereview.chromium.org/2278803004/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/scripts/nodejs/node.py (right):

https://codereview.chromium.org/2278803004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/scripts/nodejs/node.py:2: # Copyright (c)
2015 The Chromium Authors. All rights reserved.
On 2016/08/26 19:08:05, dgozman wrote:
> new files should have new copyright: no (c), 2016

Done.

https://codereview.chromium.org/2278803004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/scripts/nodejs/node.py:7: # File originally
from https://cs.chromium.org/chromium/infra/node/node.py
On 2016/08/26 19:08:05, dgozman wrote:
> Remove.

Done.

[chenwilliam, 2016-08-30 18:34:41]

I renamed the folder from scripts/nodejs to scripts/buildbot to clarify that
these are only meant to be used for buildbots and not for the dev workflow. I'll
open another CL to help developers install node.js and npm on their local
machines.

[dgozman, 2016-08-30 20:29:15]

Please update the patch description to make clear it's about buildbots.

https://codereview.chromium.org/2278803004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/package.json (right):

https://codereview.chromium.org/2278803004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/package.json:7: "lint": "eslint -c
front_end/.eslintrc.js --ignore-path front_end/.eslintignore front_end"
What is this line about? Looks unrelated.

[chenwilliam, 2016-08-30 22:28:36]

Description was changed from

==========
DevTools: Add script to use local node.js and npm

I'm working on improving our build process so we can use npm modules
on buildbots (e.g. linting, type checking).

I copied these two python scripts from the infra team which allows us
to install and run a local installation of node.js.

Original code here:
https://cs.chromium.org/chromium/infra/node/

My next step is to create a buildbot recipe that will install node.js
and eslint and lints devtools commits.

BUG=642046
==========

to

==========
DevTools: Add scripts for buildbot to use node.js/npm

I'm working on improving our build process so we can use npm modules
on buildbots (e.g. linting, type checking).

I copied these two python scripts from the infra team which will be used
by our buildbot recipe to install and run a local installation of node.js.

Original code here:
https://cs.chromium.org/chromium/infra/node/

BUG=642046
==========

[chenwilliam, 2016-08-30 22:49:14]

Updated the subject & description. PTAL. Thanks.

https://codereview.chromium.org/2278803004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/package.json (right):

https://codereview.chromium.org/2278803004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/package.json:7: "lint": "eslint -c
front_end/.eslintrc.js --ignore-path front_end/.eslintignore front_end"
On 2016/08/30 20:29:15, dgozman wrote:
> What is this line about? Looks unrelated.

This creates a new npm script so if someone runs "npm run lint" from the command
line, it will first look for a local version of eslint in the node_modules
folder and if it doesn't find a locally installed eslint module, it will look
for the globally installed eslint module.

This has two purposes:
1. I will use it in the buildbot recipe CL I'm working on (crrev.com/2290923002)
2. In a follow-up CL where I provide help for devs to install node.js, npm &
eslint, I will use this script to ensure mandatory eslint checks during
presubmits. Then we can remove lint_javascript.py because then we can use eslint
with this 1-line script.

[dgozman, 2016-08-30 23:03:20]

Thanks! lgtm

[chenwilliam, 2016-08-30 23:04:07]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2016-08-30 23:04:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 00:33:34]

Description was changed from

==========
DevTools: Add scripts for buildbot to use node.js/npm

I'm working on improving our build process so we can use npm modules
on buildbots (e.g. linting, type checking).

I copied these two python scripts from the infra team which will be used
by our buildbot recipe to install and run a local installation of node.js.

Original code here:
https://cs.chromium.org/chromium/infra/node/

BUG=642046
==========

to

==========
DevTools: Add scripts for buildbot to use node.js/npm

I'm working on improving our build process so we can use npm modules
on buildbots (e.g. linting, type checking).

I copied these two python scripts from the infra team which will be used
by our buildbot recipe to install and run a local installation of node.js.

Original code here:
https://cs.chromium.org/chromium/infra/node/

BUG=642046
==========

[commit-bot: I haz the power, 2016-08-31 00:33:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-31 00:36:03]

Description was changed from

==========
DevTools: Add scripts for buildbot to use node.js/npm

I'm working on improving our build process so we can use npm modules
on buildbots (e.g. linting, type checking).

I copied these two python scripts from the infra team which will be used
by our buildbot recipe to install and run a local installation of node.js.

Original code here:
https://cs.chromium.org/chromium/infra/node/

BUG=642046
==========

to

==========
DevTools: Add scripts for buildbot to use node.js/npm

I'm working on improving our build process so we can use npm modules
on buildbots (e.g. linting, type checking).

I copied these two python scripts from the infra team which will be used
by our buildbot recipe to install and run a local installation of node.js.

Original code here:
https://cs.chromium.org/chromium/infra/node/

BUG=642046

Committed: https://crrev.com/143336315cef6bf3f72826479af55a4f1f78c266
Cr-Commit-Position: refs/heads/master@{#415515}
==========

[commit-bot: I haz the power, 2016-08-31 00:36:04]

Patchset 3 (id:??) landed as
https://crrev.com/143336315cef6bf3f72826479af55a4f1f78c266
Cr-Commit-Position: refs/heads/master@{#415515}