Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 22782002: [SyncFS] Fix leak on MetadataDatabase (Closed)

Created:
7 years, 4 months ago by tzik
Modified:
7 years, 4 months ago
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

[SyncFS] Fix leak on MetadataDatabase The leak was introduced at http://crrev.com/216673 and supressed at http://crrev.com/216711 BUG=270742, 240165 TBR=glider NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216968

Patch Set 1 #

Patch Set 2 : leak fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -18 lines) Patch
M chrome/browser/sync_file_system/drive_backend/metadata_database.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M tools/heapcheck/suppressions.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tzik
PTAL. The patchset #1 drops the suppression and #2 should fix the leak.
7 years, 4 months ago (2013-08-12 05:17:31 UTC) #1
kinuko
Patch lgtm, though the current code looks to be prone to introduce memory leaks.
7 years, 4 months ago (2013-08-12 05:32:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/22782002/4001
7 years, 4 months ago (2013-08-12 08:35:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/22782002/4001
7 years, 4 months ago (2013-08-12 10:35:27 UTC) #4
commit-bot: I haz the power
Change committed as 216968
7 years, 4 months ago (2013-08-12 10:37:35 UTC) #5
Alexander Potapenko
7 years, 4 months ago (2013-08-12 10:49:51 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698