Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 22778004: [Android WebView] Remove use of obsolete clip (Closed)

Created:
7 years, 4 months ago by joth
Modified:
7 years, 4 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

[Android WebView] Remove use of obsolete clip Follow up to https://codereview.chromium.org/20234002/ - the old representation is no longer set so remove use of it. TBR=boliu@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216949

Patch Set 1 #

Patch Set 2 : remove declaration from header too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M android_webview/browser/in_process_view_renderer.cc View 1 chunk +1 line, -6 lines 0 comments Download
M android_webview/public/browser/draw_sw.h View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
joth
will probably land this TBR as it's a straight clean-up step in this 5-sided patch ...
7 years, 4 months ago (2013-08-11 05:08:41 UTC) #1
boliu
lgtm Why not delete the field from AwPixelInfo as well? I assume downstream is no ...
7 years, 4 months ago (2013-08-11 05:11:58 UTC) #2
joth
Thanks! On 2013/08/11 05:11:58, boliu wrote: > lgtm > > Why not delete the field ...
7 years, 4 months ago (2013-08-11 05:17:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/22778004/1
7 years, 4 months ago (2013-08-11 05:22:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/22778004/21001
7 years, 4 months ago (2013-08-11 06:13:28 UTC) #5
joth
On 2013/08/11 05:11:58, boliu wrote: > lgtm > > Why not delete the field from ...
7 years, 4 months ago (2013-08-11 06:14:12 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 06:02:05 UTC) #7
Message was sent while issue was closed.
Change committed as 216949

Powered by Google App Engine
This is Rietveld 408576698