Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 2277543004: Converted Observatory script-inset & source-inset elements (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Converted Observatory eval-box element Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 0ebf02ed5e6b7d21fdb14afea867e2866df470b7..e8c04e6ce4783749e5ff76a5b5da3c141000e1d9 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -418,7 +418,7 @@ abstract class ServiceObjectOwner extends ServiceObject {
ServiceObject getFromMap(ObservableMap map);
}
-abstract class Location {
+abstract class Location implements M.Location {
Script get script;
int get tokenPos;
}
@@ -469,7 +469,9 @@ class SourceLocation extends ServiceObject implements Location,
/// An [UnresolvedSourceLocation] represents a location in the source
// code which has not been precisely mapped to a token position.
-class UnresolvedSourceLocation extends ServiceObject implements Location {
+class UnresolvedSourceLocation extends ServiceObject
+ implements Location,
+ M.UnresolvedSourceLocation {
Script script;
String scriptUri;
int line;
@@ -1710,7 +1712,7 @@ class Isolate extends ServiceObjectOwner implements M.Isolate {
});
}
- Future<ServiceObject> _eval(ServiceObject target,
+ Future<ServiceObject> eval(ServiceObject target,
String expression) {
Map params = {
'targetId': target.id,
@@ -2209,7 +2211,7 @@ class LibraryDependency {
}
-class Library extends HeapObject implements M.LibraryRef {
+class Library extends HeapObject implements M.Library {
@observable String uri;
@reflectable final dependencies = new ObservableList<LibraryDependency>();
@reflectable final scripts = new ObservableList<Script>();
@@ -2261,7 +2263,7 @@ class Library extends HeapObject implements M.LibraryRef {
}
Future<ServiceObject> evaluate(String expression) {
- return isolate._eval(this, expression);
+ return isolate.eval(this, expression);
}
Script get rootScript {
@@ -2429,7 +2431,7 @@ class Class extends HeapObject implements M.Class {
}
Future<ServiceObject> evaluate(String expression) {
- return isolate._eval(this, expression);
+ return isolate.eval(this, expression);
}
Future<ServiceObject> setTraceAllocations(bool enable) {
@@ -2753,7 +2755,7 @@ class Instance extends HeapObject implements M.Instance {
}
Future<ServiceObject> evaluate(String expression) {
- return isolate._eval(this, expression);
+ return isolate.eval(this, expression);
}
String toString() => 'Instance($shortName)';

Powered by Google App Engine
This is Rietveld 408576698