Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: runtime/observatory/lib/src/repositories/eval.dart

Issue 2277543004: Converted Observatory script-inset & source-inset elements (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Converted Observatory eval-box element Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/repositories/eval.dart
diff --git a/runtime/observatory/lib/src/repositories/retained_size.dart b/runtime/observatory/lib/src/repositories/eval.dart
similarity index 52%
copy from runtime/observatory/lib/src/repositories/retained_size.dart
copy to runtime/observatory/lib/src/repositories/eval.dart
index b81da3475e9c2bafe7da2ab64c97a05ff7e696c7..bf423ad6caaef7f982d310e00d3dce55bfdc7be2 100644
--- a/runtime/observatory/lib/src/repositories/retained_size.dart
+++ b/runtime/observatory/lib/src/repositories/eval.dart
@@ -4,14 +4,13 @@
part of repositories;
-class RetainedSizeRepository implements M.RetainedSizeRepository {
-
- Future<M.Guarded<M.Instance>> get(M.IsolateRef i, String id) async {
+class EvalRepository extends M.EvalRepository {
+ Future<M.ObjectRef> evaluate(M.IsolateRef i, M.ObjectRef o, String e) async {
S.Isolate isolate = i as S.Isolate;
+ S.ServiceObject object = o as S.HeapObject;
assert(isolate != null);
- final response = await isolate.invokeRpc('_getRetainedSize', {
- 'targetId' : id
- });
- return new S.Guarded<S.Instance>(response);
+ assert(object != null);
+ assert(e != null);
+ return (await isolate.eval(object, e)) as M.ObjectRef;
}
}

Powered by Google App Engine
This is Rietveld 408576698