ash/common/wm/overview/window_selector.h - Issue 2276853002: [ash-md] Does not cancel overview when focus shifts from text fitler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/wm/overview/window_selector.h

Issue 2276853002: [ash-md] Does not cancel overview when focus shifts from text fitler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: [ash-md] Does not cancel overview when focus shifts from text fitler (comments) Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/common/wm/overview/window_selector.h

diff --git a/ash/common/wm/overview/window_selector.h b/ash/common/wm/overview/window_selector.h

index f8e473f246129dfd53038bb14f69d59df68a9a63..320ac74c59458f441af00564d62340e7d8b8667e 100644

--- a/ash/common/wm/overview/window_selector.h

+++ b/ash/common/wm/overview/window_selector.h

@@ -157,8 +157,8 @@ class ASH_EXPORT WindowSelector : public display::DisplayObserver,

// The number of items in the overview.

size_t num_items_;

- // Indicates if we are showing the selection widget.

- bool showing_selection_widget_;

+ // Indicates if the text filter is shown on screen (rather than above it).

+ bool showing_text_filter_;

// Window text filter widget. As the user writes on it, we filter the items

// in the overview. It is also responsible for handling overview key events,

« no previous file with comments | « no previous file | ash/common/wm/overview/window_selector.cc » ('j') | no next file with comments »