Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: content/renderer/media/android/stream_texture_factory_android.h

Issue 22766004: Fullscreen video in Android WebView (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address nits Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/content_renderer.gypi ('k') | content/renderer/media/android/stream_texture_factory_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/android/stream_texture_factory_android.h
diff --git a/content/renderer/media/android/stream_texture_factory_android.h b/content/renderer/media/android/stream_texture_factory_android.h
index f496348bd4c7e1d52912a28015361335fd163067..d41d857cf623a2d1025206dfa5a9685e27747dc0 100644
--- a/content/renderer/media/android/stream_texture_factory_android.h
+++ b/content/renderer/media/android/stream_texture_factory_android.h
@@ -7,51 +7,33 @@
#include "base/memory/scoped_ptr.h"
#include "cc/layers/video_frame_provider.h"
-#include "content/renderer/gpu/stream_texture_host_android.h"
#include "gpu/command_buffer/common/mailbox.h"
-
-namespace WebKit {
-class WebGraphicsContext3D;
-}
+#include "ui/gfx/size.h"
namespace content {
// The proxy class for the gpu thread to notify the compositor thread
// when a new video frame is available.
-class StreamTextureProxy : public StreamTextureHost::Listener {
+class StreamTextureProxy {
public:
- explicit StreamTextureProxy(StreamTextureHost* host);
- virtual ~StreamTextureProxy();
+ virtual ~StreamTextureProxy() {}
// Initialize and bind to the current thread, which becomes the thread that
// a connected client will receive callbacks on.
- void BindToCurrentThread(int32 stream_id);
+ virtual void BindToCurrentThread(int32 stream_id) = 0;
- bool IsBoundToThread() { return loop_.get() != NULL; }
+ virtual bool IsBoundToThread() = 0;
// Setting the target for callback when a frame is available. This function
// could be called on both the main thread and the compositor thread.
- void SetClient(cc::VideoFrameProvider::Client* client);
+ virtual void SetClient(cc::VideoFrameProvider::Client* client) = 0;
- // StreamTextureHost::Listener implementation:
- virtual void OnFrameAvailable() OVERRIDE;
- virtual void OnMatrixChanged(const float matrix[16]) OVERRIDE;
+ // Causes this instance to be deleted on the thread it is bound to.
+ virtual void Release() = 0;
struct Deleter {
inline void operator()(StreamTextureProxy* ptr) const { ptr->Release(); }
};
-
- private:
- // Causes this instance to be deleted on the thread it is bound to.
- void Release();
-
- scoped_ptr<StreamTextureHost> host_;
- scoped_refptr<base::MessageLoopProxy> loop_;
-
- base::Lock client_lock_;
- cc::VideoFrameProvider::Client* client_;
-
- DISALLOW_IMPLICIT_CONSTRUCTORS(StreamTextureProxy);
};
typedef scoped_ptr<StreamTextureProxy, StreamTextureProxy::Deleter>
@@ -60,43 +42,34 @@ typedef scoped_ptr<StreamTextureProxy, StreamTextureProxy::Deleter>
// Factory class for managing stream textures.
class StreamTextureFactory {
public:
- StreamTextureFactory(WebKit::WebGraphicsContext3D* context,
- GpuChannelHost* channel,
- int view_id);
- ~StreamTextureFactory();
+ virtual ~StreamTextureFactory() {}
// Create the StreamTextureProxy object.
- StreamTextureProxy* CreateProxy();
+ virtual StreamTextureProxy* CreateProxy() = 0;
// Send an IPC message to the browser process to request a java surface
// object for the given stream_id. After the the surface is created,
// it will be passed back to the WebMediaPlayerAndroid object identified by
// the player_id.
- void EstablishPeer(int32 stream_id, int player_id);
+ virtual void EstablishPeer(int32 stream_id, int player_id) = 0;
// Create the streamTexture and return the stream Id and create a client-side
// texture id to refer to the streamTexture. The texture id is produced into
// a mailbox so it can be used to ship in a VideoFrame, with a sync point for
// when the mailbox can be accessed.
- unsigned CreateStreamTexture(
+ virtual unsigned CreateStreamTexture(
unsigned texture_target,
unsigned* texture_id,
gpu::Mailbox* texture_mailbox,
- unsigned* texture_mailbox_sync_point);
+ unsigned* texture_mailbox_sync_point) = 0;
// Destroy the streamTexture for the given texture id, as well as the
// client side texture.
- void DestroyStreamTexture(unsigned texture_id);
+ virtual void DestroyStreamTexture(unsigned texture_id) = 0;
// Set the streamTexture size for the given stream Id.
- void SetStreamTextureSize(int32 texture_id, const gfx::Size& size);
-
- private:
- WebKit::WebGraphicsContext3D* context_;
- scoped_refptr<GpuChannelHost> channel_;
- int view_id_;
-
- DISALLOW_IMPLICIT_CONSTRUCTORS(StreamTextureFactory);
+ virtual void SetStreamTextureSize(int32 texture_id,
+ const gfx::Size& size) = 0;
};
} // namespace content
« no previous file with comments | « content/content_renderer.gypi ('k') | content/renderer/media/android/stream_texture_factory_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698