Make the IsClangWinBuild function GN friendly

Make the IsClangWinBuild function GN friendly

R=thakis@chromium.org
BUG=620849
Committed: https://chromium.googlesource.com/chromium/tools/build/+/c2262bf0ef1655096485abfe32b850b1522c80c8

[Sébastien Marchand, 2016-08-25 14:54:16]

PTAL.

[Nico, 2016-08-25 15:14:15]

lgtm

https://codereview.chromium.org/2276363002/diff/1/scripts/common/chromium_uti...
File scripts/common/chromium_utils.py (right):

https://codereview.chromium.org/2276363002/diff/1/scripts/common/chromium_uti...
scripts/common/chromium_utils.py:2018: re.VERBOSE)
i don't think you're using any of re.VERBOSE's features in your regex --
consider removing this?

[Sébastien Marchand, 2016-08-25 15:16:08]

https://codereview.chromium.org/2276363002/diff/1/scripts/common/chromium_uti...
File scripts/common/chromium_utils.py (right):

https://codereview.chromium.org/2276363002/diff/1/scripts/common/chromium_uti...
scripts/common/chromium_utils.py:2018: re.VERBOSE)
On 2016/08/25 15:14:15, Nico wrote:
> i don't think you're using any of re.VERBOSE's features in your regex --
> consider removing this?

Done.

[Sébastien Marchand, 2016-08-25 15:16:12]

The CQ bit was checked by sebmarchand@chromium.org

[Sébastien Marchand, 2016-08-25 15:16:13]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2276363002/#ps20001
(title: "Remove the re.VERBOSE")

[commit-bot: I haz the power, 2016-08-25 15:16:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 15:28:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 15:28:05]

Try jobs failed on following builders:
  Recipe Roll Downstream Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/30db179b3d86ee10)

[Sébastien Marchand, 2016-08-25 15:40:40]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2016-08-25 15:40:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sébastien Marchand, 2016-08-25 15:53:29]

The CQ bit was unchecked by sebmarchand@chromium.org

[Sébastien Marchand, 2016-08-25 15:58:37]

Description was changed from

==========
Make the IsClangWinBuild function GN friendly

R=thakis@chromium.org
BUG=620849
==========

to

==========
Make the IsClangWinBuild function GN friendly

R=thakis@chromium.org
BUG=620849

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/c2262bf0ef1655096485...
==========

[Sébastien Marchand, 2016-08-25 15:58:39]

Committed patchset #2 (id:20001) manually as
c2262bf0ef1655096485abfe32b850b1522c80c8.