Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22761003: Remove PDF-related extensions from the danger list on Android. (Closed)

Created:
7 years, 4 months ago by palmer
Modified:
7 years, 4 months ago
Reviewers:
asanka, cbentzel, felt
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Remove PDF-related extensions from the danger list on Android. BUG=270342 TEST=On ChromeOS and Android, PDF downloads should not trigger the "is dangerous" warning. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216862

Patch Set 1 #

Total comments: 2

Patch Set 2 : Boolean entertainment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/download/download_extensions.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
palmer
asanka for OWNERS. Others FYI.
7 years, 4 months ago (2013-08-09 21:18:24 UTC) #1
asanka
https://codereview.chromium.org/22761003/diff/1/chrome/browser/download/download_extensions.cc File chrome/browser/download/download_extensions.cc (right): https://codereview.chromium.org/22761003/diff/1/chrome/browser/download/download_extensions.cc#newcode70 chrome/browser/download/download_extensions.cc:70: #if !defined(OS_CHROMEOS) || !defined(OS_ANDROID) You want && here.
7 years, 4 months ago (2013-08-09 21:33:30 UTC) #2
palmer
https://codereview.chromium.org/22761003/diff/1/chrome/browser/download/download_extensions.cc File chrome/browser/download/download_extensions.cc (right): https://codereview.chromium.org/22761003/diff/1/chrome/browser/download/download_extensions.cc#newcode70 chrome/browser/download/download_extensions.cc:70: #if !defined(OS_CHROMEOS) || !defined(OS_ANDROID) On 2013/08/09 21:33:30, asanka wrote: ...
7 years, 4 months ago (2013-08-09 22:56:09 UTC) #3
asanka
LGTM. Thanks!
7 years, 4 months ago (2013-08-09 23:02:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/22761003/7001
7 years, 4 months ago (2013-08-09 23:33:51 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-10 00:04:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/22761003/7001
7 years, 4 months ago (2013-08-10 00:16:31 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-10 15:09:30 UTC) #8
Message was sent while issue was closed. 
Change committed as 216862

Powered by Google App Engine
This is Rietveld 408576698