Issue 22759002: [CSS Grid Layout] Add support for named grid areas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22759002: [CSS Grid Layout] Add support for named grid areas (Closed)

Created:
7 years, 4 months ago by Julien - ping for review

Modified:
7 years, 4 months ago

Reviewers:
esprehn, ojan

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

[CSS Grid Layout] Add support for named grid areas This is the final change in adding support for named grid areas: extending the resolution code to handle named grid areas. The patch is trivial as it builds on a lot of the existing grid handling code. BUG=258092 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155889

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+117 lines, -2 lines)			Patch
A	LayoutTests/fast/css-grid-layout/grid-item-named-grid-area-resolution.html	View	1 chunk	+96 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/css-grid-layout/grid-item-named-grid-area-resolution-expected.txt	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderGrid.cpp	View	2 chunks	+17 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/22759002/1

7 years, 4 months ago (2013-08-09 23:01:33 UTC) #4

Message was sent while issue was closed.

Change committed as 155889

Expand Messages | Collapse Messages