Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 22755003: Reland: Chrome side work for allowing a user to revert to their previous theme without closing ... (Closed)

Created:
7 years, 4 months ago by pkotwicz
Modified:
7 years, 4 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, extensions-reviews_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, mad+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, chromium-apps-reviews_chromium.org, Jered, not at google - send to devlin
Visibility:
Public.

Description

Reland: Chrome side work for allowing a user to revert to their previous theme without closing infobar BUG=257724 TEST=ThemeServiceTest.* R=yoz TBR=ben (for ProfileResetterTest and InstantExtendedTest) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217652

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+369 lines, -135 lines) Patch
M chrome/browser/extensions/extension_install_ui_browsertest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 4 chunks +0 lines, -35 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 4 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/profile_resetter/profile_resetter_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/themes/theme_service.h View 1 3 chunks +17 lines, -5 lines 0 comments Download
M chrome/browser/themes/theme_service.cc View 1 11 chunks +151 lines, -48 lines 0 comments Download
M chrome/browser/themes/theme_service_unittest.cc View 1 3 chunks +157 lines, -37 lines 0 comments Download
M chrome/browser/themes/theme_syncable_service.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 1 chunk +11 lines, -4 lines 0 comments Download
A chrome/test/data/extensions/theme_minimal/manifest.json View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pkotwicz
yoz@, can you please take another look? This CL is exactly the same as https://codereview.chromium.org/19462009/ ...
7 years, 4 months ago (2013-08-09 19:43:21 UTC) #1
Yoyo Zhou
Still LGTM On Aug 9, 2013 12:43 PM, <pkotwicz@chromium.org> wrote: > Reviewers: Yoyo Zhou, > ...
7 years, 4 months ago (2013-08-09 20:12:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/22755003/4001
7 years, 4 months ago (2013-08-14 18:20:31 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-14 21:33:35 UTC) #4
Message was sent while issue was closed.
Change committed as 217652

Powered by Google App Engine
This is Rietveld 408576698