Reorder member functions in FecReceiver unit test. (pt. 10)

Reorder member functions in FecReceiver unit test file.

- Place all member function definitions between test fixture
  declaration and unit tests.
- Rename GenerateFrame -> PacketizeFrame.

No functional changes are intended by this CL.

BUG=webrtc:5654
Committed: https://crrev.com/a2ece731bf036a4803a0f3805695cb853bfaea4c
Cr-Commit-Position: refs/heads/master@{#14488}

[brandtr, 2016-08-25 14:57:01]

Patchset #2 (id:20001) has been deleted

[brandtr, 2016-08-30 07:19:25]

Fix.

[brandtr, 2016-08-30 14:37:55]

Description was changed from

==========
Move stuff around in FecReceiver unit tests.

BUG=webrtc:5654
==========

to

==========
Move stuff around in FecReceiver unit tests.

BUG=webrtc:5654
==========

[brandtr, 2016-09-05 12:51:56]

Description was changed from

==========
Move stuff around in FecReceiver unit tests.

BUG=webrtc:5654
==========

to

==========
Reorder member functions in FecReceiver unit test file.

- Place all member function definitions between test fixture
  declaration and unit tests.
- Rename GenerateFrame -> PacketizeFrame.

No functional changes are intended by this CL.

BUG=webrtc:5654
==========

[brandtr, 2016-09-05 12:51:56]

brandtr@webrtc.org changed reviewers:
+ philipel@webrtc.org, stefan@webrtc.org

[philipel, 2016-09-05 13:55:58]

lgtm with a few nits

https://codereview.webrtc.org/2275303003/diff/40001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/fec_receiver_impl.h (right):

https://codereview.webrtc.org/2275303003/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/fec_receiver_impl.h:49: 
Oops?

https://codereview.webrtc.org/2275303003/diff/40001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/fec_receiver_unittest.cc (right):

https://codereview.webrtc.org/2275303003/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/fec_receiver_unittest.cc:91: 0;  // Irrelevant,
since unequal protection is turned off.
Move comment to its own line.

[brandtr, 2016-09-05 14:35:43]

Patchset #3 (id:60001) has been deleted

[brandtr, 2016-09-05 14:36:09]

Rebase

[brandtr, 2016-09-05 14:38:48]

Thanks for quick feedback!

https://codereview.webrtc.org/2275303003/diff/40001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/fec_receiver_impl.h (right):

https://codereview.webrtc.org/2275303003/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/fec_receiver_impl.h:49: 
On 2016/09/05 13:55:58, philipel wrote:
> Oops?

Intended (for symmetry!) :)

Didn't make it to the commit message though.

https://codereview.webrtc.org/2275303003/diff/40001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/fec_receiver_unittest.cc (right):

https://codereview.webrtc.org/2275303003/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/fec_receiver_unittest.cc:91: 0;  // Irrelevant,
since unequal protection is turned off.
On 2016/09/05 13:55:58, philipel wrote:
> Move comment to its own line.

Done.

[stefan-webrtc, 2016-09-05 14:39:27]

lgtm

[brandtr, 2016-09-05 14:41:08]

Patchset #4 (id:100001) has been deleted

[brandtr, 2016-09-06 14:37:32]

Rebase.

[brandtr, 2016-09-21 10:53:46]

Rebase.

[brandtr, 2016-09-27 08:22:34]

Rebase.

[brandtr, 2016-10-03 12:04:19]

Rebase.

[brandtr, 2016-10-04 06:48:02]

The CQ bit was checked by brandtr@webrtc.org

[brandtr, 2016-10-04 06:48:02]

The patchset sent to the CQ was uploaded after l-g-t-m from philipel@webrtc.org,
stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2275303003/#ps200001 (title:
"Rebase.")

[commit-bot: I haz the power, 2016-10-04 06:48:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-04 07:00:08]

Description was changed from

==========
Reorder member functions in FecReceiver unit test file.

- Place all member function definitions between test fixture
  declaration and unit tests.
- Rename GenerateFrame -> PacketizeFrame.

No functional changes are intended by this CL.

BUG=webrtc:5654
==========

to

==========
Reorder member functions in FecReceiver unit test file.

- Place all member function definitions between test fixture
  declaration and unit tests.
- Rename GenerateFrame -> PacketizeFrame.

No functional changes are intended by this CL.

BUG=webrtc:5654
==========

[commit-bot: I haz the power, 2016-10-04 07:00:09]

Committed patchset #8 (id:200001)

[commit-bot: I haz the power, 2016-10-04 07:00:20]

Description was changed from

==========
Reorder member functions in FecReceiver unit test file.

- Place all member function definitions between test fixture
  declaration and unit tests.
- Rename GenerateFrame -> PacketizeFrame.

No functional changes are intended by this CL.

BUG=webrtc:5654
==========

to

==========
Reorder member functions in FecReceiver unit test file.

- Place all member function definitions between test fixture
  declaration and unit tests.
- Rename GenerateFrame -> PacketizeFrame.

No functional changes are intended by this CL.

BUG=webrtc:5654

Committed: https://crrev.com/a2ece731bf036a4803a0f3805695cb853bfaea4c
Cr-Commit-Position: refs/heads/master@{#14488}
==========

[commit-bot: I haz the power, 2016-10-04 07:00:21]

Patchset 8 (id:??) landed as
https://crrev.com/a2ece731bf036a4803a0f3805695cb853bfaea4c
Cr-Commit-Position: refs/heads/master@{#14488}