Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 22751002: Dynamically update sign-in/Sync status in the profile creation overlay. (Closed)

Created:
7 years, 4 months ago by Bernhard Bauer
Modified:
7 years, 4 months ago
Reviewers:
Adrian Kuegel, Sergiu, ibra
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Dynamically update sign-in/Sync status in the profile creation overlay. BUG=269006 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217082

Patch Set 1 #

Patch Set 2 : sync #

Patch Set 3 : skip for tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M chrome/browser/resources/options/manage_profile_overlay.js View 1 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.h View 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.cc View 1 2 3 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
ibra
Can you please take a look? Thanks!
7 years, 4 months ago (2013-08-12 13:40:31 UTC) #1
Adrian Kuegel
lgtm
7 years, 4 months ago (2013-08-12 14:09:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/22751002/11001
7 years, 4 months ago (2013-08-12 14:11:33 UTC) #3
ibra
Adrian: a test is failing because Sync is not enabled so basically we have a ...
7 years, 4 months ago (2013-08-12 16:16:35 UTC) #4
Adrian Kuegel
LGTM
7 years, 4 months ago (2013-08-12 16:26:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/22751002/48001
7 years, 4 months ago (2013-08-12 16:26:54 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 21:38:04 UTC) #7
Message was sent while issue was closed.
Change committed as 217082

Powered by Google App Engine
This is Rietveld 408576698