Issue 22747002: setViewportEnabled on InternalSettings

Issue 22747002: setViewportEnabled on InternalSettings (Closed)

Created:
7 years, 4 months ago by rune

Modified:
7 years, 4 months ago

Reviewers:
jochen (gone - plz use gerrit), kenneth.r.christiansen

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, do-not-use

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

setViewportEnabled on InternalSettings Added possibility to --enable-viewport from internals.settings in LayoutTests. Currently viewport can only be tested through configurationForViewport which makes it impossible to test certain codepaths and more complicated cases. This CL is a pre-condition for a test in another CL I am preparing. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156301

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Mac compile issue: removed unused member variable #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -4 lines)			Patch
A	LayoutTests/fast/viewport/viewport-enabled.html	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/viewport/viewport-enabled-expected.txt	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/page/Settings.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	Source/core/page/Settings.cpp	View		2 chunks	+11 lines, -0 lines	0 comments	Download
M	Source/core/testing/InternalSettings.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/testing/InternalSettings.cpp	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/core/testing/InternalSettings.idl	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/web/WebSettingsImpl.h	View	1 2	2 chunks	+1 line, -2 lines	0 comments	Download
M	Source/web/WebSettingsImpl.cpp	View		3 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/22747002/3001

7 years, 4 months ago (2013-08-19 09:07:37 UTC) #5

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 4 months ago (2013-08-19 09:39:38 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/22747002/16002

7 years, 4 months ago (2013-08-19 09:56:42 UTC) #7

Message was sent while issue was closed.

Change committed as 156301

Expand Messages | Collapse Messages