Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 22746004: Add API to WebFrame to enable/disable caret. (Closed)

Created:
7 years, 4 months ago by varunjain
Modified:
7 years, 4 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, eae+blinkwatch, abarth-chromium
Visibility:
Public.

Description

Add API to WebFrame to enable/disable caret. This can be used to disable the caret when the embedder wants to draw its own caret (for example, for touch based text editing, the browser shows a caret handle which can be dragged around with touch). BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155971

Patch Set 1 #

Total comments: 2

Patch Set 2 : patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M Source/web/WebFrameImpl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebFrameImpl.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebFrame.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
varunjain
7 years, 4 months ago (2013-08-09 17:55:20 UTC) #1
varunjain
added chromium version of dglazkov
7 years, 4 months ago (2013-08-09 18:09:01 UTC) #2
abarth-chromium
https://codereview.chromium.org/22746004/diff/1/Source/web/WebFrameImpl.cpp File Source/web/WebFrameImpl.cpp (right): https://codereview.chromium.org/22746004/diff/1/Source/web/WebFrameImpl.cpp#newcode1371 Source/web/WebFrameImpl.cpp:1371: frame()->selection()->setCaretVisible(enable); Is there a reason to use a different ...
7 years, 4 months ago (2013-08-12 18:40:34 UTC) #3
varunjain
https://codereview.chromium.org/22746004/diff/1/Source/web/WebFrameImpl.cpp File Source/web/WebFrameImpl.cpp (right): https://codereview.chromium.org/22746004/diff/1/Source/web/WebFrameImpl.cpp#newcode1371 Source/web/WebFrameImpl.cpp:1371: frame()->selection()->setCaretVisible(enable); On 2013/08/12 18:40:34, abarth wrote: > Is there ...
7 years, 4 months ago (2013-08-12 21:43:40 UTC) #4
abarth-chromium
lgtm
7 years, 4 months ago (2013-08-12 23:24:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/22746004/6001
7 years, 4 months ago (2013-08-12 23:25:59 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-13 02:08:07 UTC) #7
Message was sent while issue was closed.
Change committed as 155971

Powered by Google App Engine
This is Rietveld 408576698