Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: src/code-stubs.cc

Issue 22745003: Remove platform-specific dead code for KeyedStores (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/flag-definitions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 575 matching lines...) Expand 10 before | Expand all | Expand 10 after
586 CreateAllocationSiteStub stub; 586 CreateAllocationSiteStub stub;
587 stub.GetCode(isolate)->set_is_pregenerated(true); 587 stub.GetCode(isolate)->set_is_pregenerated(true);
588 } 588 }
589 589
590 590
591 void KeyedStoreElementStub::Generate(MacroAssembler* masm) { 591 void KeyedStoreElementStub::Generate(MacroAssembler* masm) {
592 switch (elements_kind_) { 592 switch (elements_kind_) {
593 case FAST_ELEMENTS: 593 case FAST_ELEMENTS:
594 case FAST_HOLEY_ELEMENTS: 594 case FAST_HOLEY_ELEMENTS:
595 case FAST_SMI_ELEMENTS: 595 case FAST_SMI_ELEMENTS:
596 case FAST_HOLEY_SMI_ELEMENTS: { 596 case FAST_HOLEY_SMI_ELEMENTS:
597 KeyedStoreStubCompiler::GenerateStoreFastElement(masm,
598 is_js_array_,
599 elements_kind_,
600 store_mode_);
601 }
602 break;
603 case FAST_DOUBLE_ELEMENTS: 597 case FAST_DOUBLE_ELEMENTS:
604 case FAST_HOLEY_DOUBLE_ELEMENTS: 598 case FAST_HOLEY_DOUBLE_ELEMENTS:
605 KeyedStoreStubCompiler::GenerateStoreFastDoubleElement(masm,
606 is_js_array_,
607 store_mode_);
608 break;
609 case EXTERNAL_BYTE_ELEMENTS: 599 case EXTERNAL_BYTE_ELEMENTS:
610 case EXTERNAL_UNSIGNED_BYTE_ELEMENTS: 600 case EXTERNAL_UNSIGNED_BYTE_ELEMENTS:
611 case EXTERNAL_SHORT_ELEMENTS: 601 case EXTERNAL_SHORT_ELEMENTS:
612 case EXTERNAL_UNSIGNED_SHORT_ELEMENTS: 602 case EXTERNAL_UNSIGNED_SHORT_ELEMENTS:
613 case EXTERNAL_INT_ELEMENTS: 603 case EXTERNAL_INT_ELEMENTS:
614 case EXTERNAL_UNSIGNED_INT_ELEMENTS: 604 case EXTERNAL_UNSIGNED_INT_ELEMENTS:
615 case EXTERNAL_FLOAT_ELEMENTS: 605 case EXTERNAL_FLOAT_ELEMENTS:
616 case EXTERNAL_DOUBLE_ELEMENTS: 606 case EXTERNAL_DOUBLE_ELEMENTS:
617 case EXTERNAL_PIXEL_ELEMENTS: 607 case EXTERNAL_PIXEL_ELEMENTS:
618 KeyedStoreStubCompiler::GenerateStoreExternalArray(masm, elements_kind_); 608 UNREACHABLE();
619 break; 609 break;
620 case DICTIONARY_ELEMENTS: 610 case DICTIONARY_ELEMENTS:
621 KeyedStoreStubCompiler::GenerateStoreDictionaryElement(masm); 611 KeyedStoreStubCompiler::GenerateStoreDictionaryElement(masm);
622 break; 612 break;
623 case NON_STRICT_ARGUMENTS_ELEMENTS: 613 case NON_STRICT_ARGUMENTS_ELEMENTS:
624 UNREACHABLE(); 614 UNREACHABLE();
625 break; 615 break;
626 } 616 }
627 } 617 }
628 618
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
796 InstallDescriptor(isolate, &stub3); 786 InstallDescriptor(isolate, &stub3);
797 } 787 }
798 788
799 InternalArrayConstructorStub::InternalArrayConstructorStub( 789 InternalArrayConstructorStub::InternalArrayConstructorStub(
800 Isolate* isolate) { 790 Isolate* isolate) {
801 InternalArrayConstructorStubBase::GenerateStubsAheadOfTime(isolate); 791 InternalArrayConstructorStubBase::GenerateStubsAheadOfTime(isolate);
802 } 792 }
803 793
804 794
805 } } // namespace v8::internal 795 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/flag-definitions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698