chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc - Issue 22743002: Convert OneClickSigninBubbleViewTest to browser_tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

Issue 22743002: Convert OneClickSigninBubbleViewTest to browser_tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove tabs Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/sync/one_click_signin_bubble_view.h ('k') | chrome/browser/ui/views/sync/one_click_signin_bubble_view_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

diff --git a/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc b/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

index 97beda1afc6793861063fbe178e30e045c692c15..4bb001b2fc4ce73f0912339246e6c99811d2253c 100644

--- a/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

+++ b/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

@@ -46,6 +46,7 @@ enum OneClickSigninBubbleColumnTypes {

// static

OneClickSigninBubbleView* OneClickSigninBubbleView::bubble_view_ = NULL;

+bool OneClickSigninBubbleView::close_on_deactivate_for_testing_ = true;

// static

void OneClickSigninBubbleView::ShowBubble(

@@ -76,7 +77,9 @@ void OneClickSigninBubbleView::ShowBubble(

break;

}

- views::BubbleDelegateView::CreateBubble(bubble_view_)->Show();

+ views::BubbleDelegateView::CreateBubble(bubble_view_);

+ bubble_view_->set_close_on_deactivate(close_on_deactivate_for_testing_);

+ bubble_view_->GetWidget()->Show();

}

// static