Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1507)

Issue 2274183003: Force expandEnd/RangeToSentenceBoundary to return a valid EphemeralRange (Closed)

Created:
4 years, 3 months ago by Xiaocheng
Modified:
4 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Force expandEnd/RangeToSentenceBoundary to return a valid EphemeralRange This is a first-aid patch that make expandEnd/RangeToSentenceBoundary() compare the sentence boundaries found with the input range before returning, so that the returned range is always a super-range of the input range, and hence, a valid EphemeralRange. This patch does not fix the root cause of the bugs, as we do not expect startOfSentence()'s return value to be beyond that of endOfSentence()'s. It simply stops the crashing at expandEnd/RangeToSentenceBoundary. BUG=640905 TEST=n/a; this is a first-aid patch Committed: https://crrev.com/5345d9cf9d3d0ad37cb56edd31aa0686d3ff22c5 Cr-Commit-Position: refs/heads/master@{#414624}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Xiaocheng
PTAL.
4 years, 3 months ago (2016-08-25 10:04:32 UTC) #5
yosin_UTC9
lgtm We'll fix boundary related calculation next quarter...
4 years, 3 months ago (2016-08-26 01:35:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274183003/1
4 years, 3 months ago (2016-08-26 01:41:33 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 01:46:35 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 01:49:16 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5345d9cf9d3d0ad37cb56edd31aa0686d3ff22c5
Cr-Commit-Position: refs/heads/master@{#414624}

Powered by Google App Engine
This is Rietveld 408576698