Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 22736003: skia: remove gpu/gl from include path. (Closed)

Created:
7 years, 4 months ago by Torne
Modified:
7 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

skia: remove gpu/gl from include path. include/gpu/gl is not normally part of the skia include path; don't add it to include_dirs when building skia inside chromium. References to gl headers have been fixed to qualify the path properly. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217027

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M skia/skia_library.gypi View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Torne
This can't actually land until Blink https://codereview.chromium.org/22582006/ rolls into Chromium but after that it should ...
7 years, 4 months ago (2013-08-09 11:12:43 UTC) #1
djsollen
lgtm pending the roll.
7 years, 4 months ago (2013-08-09 12:22:37 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 4 months ago (2013-08-12 10:04:30 UTC) #3
Torne
7 years, 4 months ago (2013-08-12 10:04:45 UTC) #4
mkosiba (inactive)
lgtm
7 years, 4 months ago (2013-08-12 10:05:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/22736003/1
7 years, 4 months ago (2013-08-12 10:09:35 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-12 10:19:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/22736003/1
7 years, 4 months ago (2013-08-12 12:11:37 UTC) #8
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 17:26:01 UTC) #9
Message was sent while issue was closed.
Change committed as 217027

Powered by Google App Engine
This is Rietveld 408576698