Directly call ChunkDemuxer::Initialize completion callback.

media/filters/chunk_demuxer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/filters/chunk_demuxer.h"
 
 #include <algorithm>
 #include <limits>
 #include <list>
 #include <utility>
@@ skipping 409 matching lines @@
   DCHECK(!open_cb_.is_null());
   DCHECK(!encrypted_media_init_data_cb_.is_null());
 }
 
 std::string ChunkDemuxer::GetDisplayName() const {
   return "ChunkDemuxer";
 }
 
 void ChunkDemuxer::Initialize(
     DemuxerHost* host,
     const PipelineStatusCB& cb,

[xhwang, 2016/09/16 23:41:47]

nit on naming: This code is old. We use |status_cb| in demuxer.h, and |cb| here.
Then we use |init_cb_| for the saved callback. Maybe we should just always use
|init_cb|.

[alokp, 2016/09/17 00:06:05]

IIUC do you want me to change the function argument name cb -> init_cb?

[xhwang, 2016/09/17 03:58:24]

A TODO for the renaming should be good. Thank you!

[alokp, 2016/09/17 05:43:14]

I can make this trivial change while I am already here. I just wanted to confirm
if this what you wanted me to do.

     bool enable_text_tracks) {
   DVLOG(1) << "Init()";
 
   base::AutoLock auto_lock(lock_);
-
-  // The |init_cb_| must only be run after this method returns, so always post.
-  init_cb_ = BindToCurrentLoop(cb);
   if (state_ == SHUTDOWN) {
-    base::ResetAndReturn(&init_cb_).Run(DEMUXER_ERROR_COULD_NOT_OPEN);
+    // Init cb must only be run after this method returns, so always post.
+    base::ThreadTaskRunnerHandle::Get()->PostTask(
+        FROM_HERE, base::Bind(cb, DEMUXER_ERROR_COULD_NOT_OPEN));
     return;
   }
+
   DCHECK_EQ(state_, WAITING_FOR_INIT);
   host_ = host;
+  // Do not post init_cb once this function returns because if there is an
+  // error after initialization, the error might be reported before init_cb
+  // has a chance to run. This is because ChunkDemuxer::ReportError_Locked
+  // directly calls DemuxerHost::OnDemuxerError: crbug.com/633016.
+  init_cb_ = cb;
   enable_text_ = enable_text_tracks;
 
   ChangeState_Locked(INITIALIZING);
 
   base::ResetAndReturn(&open_cb_).Run();
 }
 
 void ChunkDemuxer::Stop() {
   DVLOG(1) << "Stop()";
   Shutdown();
@@ skipping 818 matching lines @@
 }
 
 void ChunkDemuxer::ShutdownAllStreams() {
   for (MediaSourceStateMap::iterator itr = source_state_map_.begin();
        itr != source_state_map_.end(); ++itr) {
     itr->second->Shutdown();
   }
 }
 
 }  // namespace media