Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 22730003: Warm-up the App List when enabled from the webstore and not shown. (Closed)

Created:
7 years, 4 months ago by tapted
Modified:
7 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Warm-up the App List when enabled from the webstore and not shown. On Mac, the app list is not warmed up when Chrome starts. If it is not shown, its model will not be updated with the changes due to app install. If shown, the app is not shown at all if it is still installing, and it will not be highlighted if shown after install completes. This CL Exposes a CreateForProfile function to the AppListService, which allows an app list to be created but not shown. BUG=267814 TEST=From a profile that has not used the app launcher (it can have apps), install an app from the web store. Launch the app launcher. During install, it should show install progress. After install, it should have the item highlighted (whether first shown before or after install completes). TBR=xiyuan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216954

Patch Set 1 #

Patch Set 2 : Expose CreateAppList #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -27 lines) Patch
M chrome/browser/extensions/api/webstore_private/webstore_private_api.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_disabled.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_mac.mm View 1 4 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_service_ash.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/app_list/app_list_controller_win.cc View 1 2 5 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tapted
koz, PTAL. I had traced this with debug statements in the earlier CL, but I ...
7 years, 4 months ago (2013-08-09 06:40:47 UTC) #1
tapted
+chrome-apps-syd-reviews You can see my first attempt in Patch Set 1, which simply made the ...
7 years, 4 months ago (2013-08-09 06:42:27 UTC) #2
tapted
btw - patched this in on Windows & double checked, both: - ./chrome.exe --disable-app-list && ...
7 years, 4 months ago (2013-08-09 07:54:21 UTC) #3
koz (OOO until 15th September)
Cool! lgtm
7 years, 4 months ago (2013-08-12 00:08:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/22730003/17001
7 years, 4 months ago (2013-08-12 04:43:51 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=20060
7 years, 4 months ago (2013-08-12 05:02:02 UTC) #6
tapted
TBR xiyuan for mechanical change in chrome/browser/ui/ash/app_list/app_list_service_ash.cc
7 years, 4 months ago (2013-08-12 05:53:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/22730003/17001
7 years, 4 months ago (2013-08-12 05:54:22 UTC) #8
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 07:44:44 UTC) #9
Message was sent while issue was closed.
Change committed as 216954

Powered by Google App Engine
This is Rietveld 408576698