Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 22724002: Invokes NotificationDelegate::Close in message center. (Closed)

Created:
7 years, 4 months ago by Jun Mukai
Modified:
7 years, 4 months ago
Reviewers:
dewittj
CC:
chromium-reviews
Visibility:
Public.

Description

Invokes NotificationDelegate::Close in message center. Now it's owned by message_center, so it's more natural to call in MessageCenterImpl. BUG=270305 R=dewittj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216850

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M chrome/browser/notifications/message_center_notification_manager.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/notifications/message_center_notification_manager.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ui/message_center/message_center_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jun Mukai
7 years, 4 months ago (2013-08-09 00:12:31 UTC) #1
dewittj
lgtm
7 years, 4 months ago (2013-08-09 18:47:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/22724002/1
7 years, 4 months ago (2013-08-09 20:32:16 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-10 14:10:31 UTC) #4
Message was sent while issue was closed.
Change committed as 216850

Powered by Google App Engine
This is Rietveld 408576698