Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 22723005: Remove gc extension from webkit/support (Closed)

Created:
7 years, 4 months ago by jamesr
Modified:
7 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Remove gc extension from webkit/support Nothing depends on this, although some webkit_unit_tests still depend on --expose-gc. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217054

Patch Set 1 #

Patch Set 2 : put gc_extension in content/shell/renderer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -63 lines) Patch
M content/content_shell.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/shell/renderer/gc_extension.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/renderer/gc_extension.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/shell_render_process_observer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D webkit/support/gc_extension.h View 1 chunk +0 lines, -23 lines 0 comments Download
D webkit/support/gc_extension.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M webkit/support/webkit_support.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jamesr
7 years, 4 months ago (2013-08-09 02:17:05 UTC) #1
kinuko
lgtm!
7 years, 4 months ago (2013-08-09 02:19:59 UTC) #2
jamesr
D'oh, this is also used in content/shell/. I'll move it out of webkit/support/ instead of ...
7 years, 4 months ago (2013-08-09 02:29:37 UTC) #3
jamesr
Jochen, what do you think of this?
7 years, 4 months ago (2013-08-09 03:16:25 UTC) #4
jochen (gone - plz use gerrit)
lgtm we could also consider to rewrite all layout tests to use gc() instead of ...
7 years, 4 months ago (2013-08-09 03:30:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/22723005/6001
7 years, 4 months ago (2013-08-09 23:07:47 UTC) #6
jamesr
On 2013/08/09 03:30:42, jochen wrote: > lgtm > > we could also consider to rewrite ...
7 years, 4 months ago (2013-08-09 23:08:21 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=186128
7 years, 4 months ago (2013-08-10 04:45:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/22723005/6001
7 years, 4 months ago (2013-08-12 19:36:26 UTC) #9
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 19:39:52 UTC) #10
Message was sent while issue was closed.
Change committed as 217054

Powered by Google App Engine
This is Rietveld 408576698