Issue 22720004: Tweak pixel-by-pixel layout for Notifications message center.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22720004: Tweak pixel-by-pixel layout for Notifications message center. (Closed)

Created:
7 years, 4 months ago by dewittj

Modified:
7 years, 4 months ago

Reviewers:
jianli

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Tweak pixel-by-pixel layout for Notifications message center. This matches an updated spec. Now, the menu for profile switching has a checkbox next to the currently selected profile. Additionally, the leftmost edges of all the visible controls are now lined up. R=jianli@chromium.org BUG=269757 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216781

Patch Set 1 #

Patch Set 2 : Rename some constants for clarity. #

Patch Set 3 : Fix typo #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -21 lines)			Patch
	M	ui/message_center/views/notifier_settings_view.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
	M	ui/message_center/views/notifier_settings_view.cc	View	1 2	9 chunks	+49 lines, -21 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/22720004/5001

7 years, 4 months ago (2013-08-09 17:32:25 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 4 months ago (2013-08-09 21:07:36 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/22720004/5001

7 years, 4 months ago (2013-08-09 21:19:40 UTC) #5

Message was sent while issue was closed.

Change committed as 216781

Expand Messages | Collapse Messages