chrome/browser/android/download/download_manager_service.cc - Issue 2271913002: [Downloads] Remove externally deleted items from downloads history

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/download/download_manager_service.cc

Issue 2271913002: [Downloads] Remove externally deleted items from downloads history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: dfalcantara@ review changes Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java ('k') | tools/metrics/actions/actions.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/download/download_manager_service.cc

diff --git a/chrome/browser/android/download/download_manager_service.cc b/chrome/browser/android/download/download_manager_service.cc

index 18eb7dd085503fc5f657d406ea21881c3990753e..3c7e9fba92f79feea815d84a86e9fedca2920cf0 100644

--- a/chrome/browser/android/download/download_manager_service.cc

+++ b/chrome/browser/android/download/download_manager_service.cc

@@ -173,6 +173,12 @@ void DownloadManagerService::CheckForExternallyRemovedDownloads(

JNIEnv* env,

const JavaParamRef<jobject>& obj,

bool is_off_the_record) {

+ // Once the history query is complete, download_history.cc will check for the

+ // removal of history files. If the history query is not yet complete, ignore

+ // requests to check for externally removed downloads.

+ if (!is_history_query_complete_)

+ return;

content::DownloadManager* manager = GetDownloadManager(is_off_the_record);

if (!manager)

return;