Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 227153004: Adds the foundation for extensions test suite. (Closed)

Created:
6 years, 8 months ago by tfarina
Modified:
6 years, 8 months ago
Reviewers:
James Cook, Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Adds the foundation for extensions test suite. We need to build our custom test suite and run it because we will need to setup some extensions pieces in order to make the existing tests pass. Mainly, the next work will be to setup an ExtensionsClient and call it from our TestSuite. This just adds the foundation from which we will iterate and fix the current failing unit tests. It does not do anything else different from the current behavior. BUG=348066 TEST=extensions_unittests still runs R=yoz@chromium.org,jamescook@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262655

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -1 line) Patch
M extensions/extensions.gyp View 2 chunks +1 line, -1 line 0 comments Download
A extensions/test/extensions_unittests_main.cc View 1 chunk +45 lines, -0 lines 1 comment Download

Messages

Total messages: 32 (0 generated)
tfarina
PTAL. Thanks,
6 years, 8 months ago (2014-04-07 01:35:11 UTC) #1
James Cook
This looks fine to me, but I'll defer to yoz@ who has been looking at ...
6 years, 8 months ago (2014-04-07 16:10:31 UTC) #2
Yoyo Zhou
LGTM https://chromiumcodereview.appspot.com/227153004/diff/1/extensions/test/extensions_unittests_main.cc File extensions/test/extensions_unittests_main.cc (right): https://chromiumcodereview.appspot.com/227153004/diff/1/extensions/test/extensions_unittests_main.cc#newcode28 extensions/test/extensions_unittests_main.cc:28: void ExtensionsTestSuite::Initialize() { It doesn't seem like these ...
6 years, 8 months ago (2014-04-07 23:20:03 UTC) #3
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-04-09 03:45:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 03:45:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 04:42:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 04:48:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 04:53:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 04:58:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 06:43:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 06:51:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 06:57:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 07:03:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 07:10:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 07:17:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 07:23:54 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 07:29:53 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 07:38:15 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 07:45:37 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 07:52:17 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 08:00:03 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 08:06:51 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 08:14:31 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 09:06:41 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 09:15:01 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 09:22:18 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 09:30:05 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 09:42:12 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 09:51:21 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 11:11:08 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
6 years, 8 months ago (2014-04-09 11:22:50 UTC) #31
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 12:23:01 UTC) #32
Message was sent while issue was closed.
Change committed as 262655

Powered by Google App Engine
This is Rietveld 408576698