Enable webview and browser-plugin as custom elements in Chrome Apps

Enable webview and browser-plugin as custom elements in Chrome Apps

Once http://crrev.com/22652003 lands, and Blink rolls, this is the Chromium
side that will allow the use of <webview> as a custom element. The actual
changes to webview to use the custom element API will come in a separate patch.

BUG=178663
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216790

[not at google - send to devlin, 2013-08-08 21:20:25]

https://codereview.chromium.org/22709003/diff/1/chrome/renderer/extensions/di...
File chrome/renderer/extensions/dispatcher.cc (right):

https://codereview.chromium.org/22709003/diff/1/chrome/renderer/extensions/di...
chrome/renderer/extensions/dispatcher.cc:476: is_app |= extension->is_app();
you probably want is_platform_app()

https://codereview.chromium.org/22709003/diff/1/chrome/renderer/extensions/di...
chrome/renderer/extensions/dispatcher.cc:1159: bool
Dispatcher::IsWithinPlatformApp(const WebFrame* frame) {
I would rather we fix this method to work without a frame (basically, what
you're doing already with the iterating over active extensions) and call that
from WebKitInitialized and the other place.

[Fady Samuel, 2013-08-08 22:46:52]

PTAL

[not at google - send to devlin, 2013-08-08 22:48:23]

lgtm

https://codereview.chromium.org/22709003/diff/7001/chrome/renderer/extensions...
File chrome/renderer/extensions/dispatcher.cc (right):

https://codereview.chromium.org/22709003/diff/7001/chrome/renderer/extensions...
chrome/renderer/extensions/dispatcher.cc:1162: is_platform_app |= extension &&
extension->is_platform_app();
you could avoid the is_platform_app variable by returning true from here.

[not at google - send to devlin, 2013-08-08 22:51:44]

https://codereview.chromium.org/22709003/diff/7001/chrome/renderer/extensions...
File chrome/renderer/extensions/dispatcher.cc (right):

https://codereview.chromium.org/22709003/diff/7001/chrome/renderer/extensions...
chrome/renderer/extensions/dispatcher.cc:1162: is_platform_app |= extension &&
extension->is_platform_app();
On 2013/08/08 22:48:23, kalman wrote:
> you could avoid the is_platform_app variable by returning true from here.

actually scrap that, leave what you have - since it'd be nice to sanity CHECK()
that if this is a platform app process then there's only a single extension in
that set. Or something very wrong is happening.

[Fady Samuel, 2013-08-08 22:51:52]

https://codereview.chromium.org/22709003/diff/7001/chrome/renderer/extensions...
File chrome/renderer/extensions/dispatcher.cc (right):

https://codereview.chromium.org/22709003/diff/7001/chrome/renderer/extensions...
chrome/renderer/extensions/dispatcher.cc:1162: is_platform_app |= extension &&
extension->is_platform_app();
On 2013/08/08 22:48:23, kalman wrote:
> you could avoid the is_platform_app variable by returning true from here.

Ohh of course. I'm jetlagged and my brain is not all there. Fixed. Will CQ once
Blink rolls.

[commit-bot: I haz the power, 2013-08-09 20:48:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/22709003/12001

[commit-bot: I haz the power, 2013-08-10 00:28:25]

Change committed as 216790