chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java - Issue 2270873002: Put WebAPK Android Manifest keys in dedicated file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java

Issue 2270873002: Put WebAPK Android Manifest keys in dedicated file (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into meta_data_class Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java ('k') | chrome/android/webapk/libs/common/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java

diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java

index ad887864e0ce81c650bf7bae2cd2fd045300ca56..4d8b6a02f9fbe10ee5194bf840471f04d2cc1b84 100644

--- a/chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java

+++ b/chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java

@@ -17,6 +17,7 @@ import org.chromium.chrome.browser.ShortcutHelper;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.content_public.common.ScreenOrientationValues;

import org.chromium.testing.local.LocalRobolectricTestRunner;

+import org.chromium.webapk.lib.common.WebApkMetaDataKeys;

import org.junit.Assert;

import org.junit.Before;

@@ -162,11 +163,10 @@ public class ManifestUpgradeDetectorTest {

private void setMetaData(

String manifestUrl, String startUrl, String iconUrl, long iconMurmur2Hash) {

Bundle bundle = new Bundle();

- bundle.putString(ManifestUpgradeDetector.META_DATA_WEB_MANIFEST_URL, manifestUrl);

- bundle.putString(ManifestUpgradeDetector.META_DATA_START_URL, startUrl);

- bundle.putString(ManifestUpgradeDetector.META_DATA_ICON_URL, iconUrl);

- bundle.putString(

- ManifestUpgradeDetector.META_DATA_ICON_MURMUR2_HASH, iconMurmur2Hash + "L");

+ bundle.putString(WebApkMetaDataKeys.WEB_MANIFEST_URL, manifestUrl);

+ bundle.putString(WebApkMetaDataKeys.START_URL, startUrl);

+ bundle.putString(WebApkMetaDataKeys.ICON_URL, iconUrl);

+ bundle.putString(WebApkMetaDataKeys.ICON_MURMUR2_HASH, iconMurmur2Hash + "L");

ApplicationInfo appInfo = new ApplicationInfo();

appInfo.metaData = bundle;