Make sure proper double tap scale gets recorded for next double tap.

Make sure proper double tap scale gets recorded for next double tap.

BUG=260644
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155929

[Mathias Hällman, 2013-08-09 07:13:00]

This error was introduced during refactoring in
https://codereview.chromium.org/19281007/

[jochen (gone - plz use gerrit), 2013-08-09 07:25:55]

not sure what the bug is, nor why this fixes anything?

[Mathias Hällman, 2013-08-09 07:46:02]

On 2013/08/09 07:25:55, jochen wrote:
> not sure what the bug is, nor why this fixes anything?

I haven't noticed any direct bug, I was just doing further refactoring around
this code and noticed something that didn't seem right. That is, that
m_doubleTapZoomPageScaleFactor won't get properly set to the actual scale we're
animating to. Before the refactoring in the other issue, scale would be set to
minimumPageScaleFactor() in computeScaleAndScrollForBlockRect, but now scale may
get a different value in that method and then we may still zoom out to
minimumPageScaleFactor().

[aelias_OOO_until_Jul13, 2013-08-09 18:37:49]

Indeed, thanks for following up.  I think I've noticed the symptoms in practice
of some double-tap gestures mysteriously not working.  lgtm

[philipj_slow, 2013-08-12 12:01:32]

Mathias is on vacation and has asked me to follow this up if needed. I'll just
check the commit box then, and hope the commit bot doesn't notice I'm not
Mathias.

[philipj_slow, 2013-08-12 12:02:25]

Nope, "An error occurred while trying to update the issue." aelias, do you have
permission to check the box? Mathias is away for two weeks, and it'd be a shame
to have conflicts creep in for a simple fix like this.

[jochen (gone - plz use gerrit), 2013-08-12 12:04:28]

lgtm

[commit-bot: I haz the power, 2013-08-12 12:04:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mathiash@opera.com/22706009/3001

[commit-bot: I haz the power, 2013-08-12 13:30:04]

Change committed as 155929

[philipj_slow, 2013-08-21 11:22:17]

Thanks!