Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2270563002: Expand the workaround for Strict Mode issues on L Consumer. (Closed)

Created:
4 years, 4 months ago by Donn Denman
Modified:
4 years, 4 months ago
Reviewers:
Ted C, Peter Wen
CC:
chromium-reviews, Peter Wen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expand the workaround for Strict Mode issues on L Consumer. Expands the code section that allows I/O during ChromeActivity#setContentView. Now I/O is also allowed during the resource inflation of the toolbar container. This works around Strict Mode violations we're seeing on tests running on the L Consumer configuration. BUG=639352 Committed: https://crrev.com/a1235d7c247cbb55a06f648cda088272fb3c8729 Cr-Commit-Position: refs/heads/master@{#413838}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Just changed a comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 1 chunk +10 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Donn Denman
Ted, PTAL. I'm thinking we should also verify that there are not additional problems lurking. ...
4 years, 4 months ago (2016-08-23 00:36:22 UTC) #2
Donn Denman
[cc Peter]
4 years, 4 months ago (2016-08-23 16:19:52 UTC) #3
Peter Wen
lgtm Unfortunately this is out of our control. https://codereview.chromium.org/2270563002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java (right): https://codereview.chromium.org/2270563002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java#newcode346 chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:346: // ...
4 years, 4 months ago (2016-08-23 17:36:46 UTC) #5
Donn Denman
Ted, I'm thinking it's easiest to just try this to see if it works on ...
4 years, 4 months ago (2016-08-23 17:50:51 UTC) #6
Ted C
lgtm
4 years, 4 months ago (2016-08-23 18:13:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270563002/20001
4 years, 4 months ago (2016-08-23 19:35:45 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-23 21:19:41 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 21:23:12 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a1235d7c247cbb55a06f648cda088272fb3c8729
Cr-Commit-Position: refs/heads/master@{#413838}

Powered by Google App Engine
This is Rietveld 408576698